third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp - Issue 1442843004: Oilpan: tidy up ChromeClientImplTest's ChromeClientImpl ref.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp

Issue 1442843004: Oilpan: tidy up ChromeClientImplTest's ChromeClientImpl ref. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp b/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp

index 6dbafb4a5706bbc007ef0f87a3627ad50bf30599..d3d34f2f292da5edc9242298969974af2a9564fd 100644

--- a/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp

+++ b/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp

@@ -119,7 +119,7 @@ protected:

WebViewImpl* m_webView;

WebFrame* m_mainFrame;

TestWebFrameClient m_webFrameClient;

- ChromeClientImpl* m_chromeClientImpl;

+ RawPtrWillBePersistent<ChromeClientImpl> m_chromeClientImpl;

haraken 2015/11/14 07:14:16 RefPtrWillBePersistent?

sof 2015/11/14 08:12:27 I'll pass; if anyone wants to work on improving !O

};

TEST_F(GetNavigationPolicyTest, LeftClick)

« no previous file with comments | « no previous file | no next file » | no next file with comments »