Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp

Issue 1442843004: Oilpan: tidy up ChromeClientImplTest's ChromeClientImpl ref. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 m_chromeClientImpl->show(NavigationPolicyIgnore); 112 m_chromeClientImpl->show(NavigationPolicyIgnore);
113 return m_result == WebNavigationPolicyNewPopup; 113 return m_result == WebNavigationPolicyNewPopup;
114 } 114 }
115 115
116 protected: 116 protected:
117 WebNavigationPolicy m_result; 117 WebNavigationPolicy m_result;
118 TestWebViewClient m_webViewClient; 118 TestWebViewClient m_webViewClient;
119 WebViewImpl* m_webView; 119 WebViewImpl* m_webView;
120 WebFrame* m_mainFrame; 120 WebFrame* m_mainFrame;
121 TestWebFrameClient m_webFrameClient; 121 TestWebFrameClient m_webFrameClient;
122 ChromeClientImpl* m_chromeClientImpl; 122 RawPtrWillBePersistent<ChromeClientImpl> m_chromeClientImpl;
haraken 2015/11/14 07:14:16 RefPtrWillBePersistent?
sof 2015/11/14 08:12:27 I'll pass; if anyone wants to work on improving !O
123 }; 123 };
124 124
125 TEST_F(GetNavigationPolicyTest, LeftClick) 125 TEST_F(GetNavigationPolicyTest, LeftClick)
126 { 126 {
127 int modifiers = 0; 127 int modifiers = 0;
128 WebMouseEvent::Button button = WebMouseEvent::ButtonLeft; 128 WebMouseEvent::Button button = WebMouseEvent::ButtonLeft;
129 bool asPopup = false; 129 bool asPopup = false;
130 EXPECT_EQ(WebNavigationPolicyNewForegroundTab, 130 EXPECT_EQ(WebNavigationPolicyNewForegroundTab,
131 getNavigationPolicyWithMouseEvent(modifiers, button, asPopup)); 131 getNavigationPolicyWithMouseEvent(modifiers, button, asPopup));
132 } 132 }
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
256 256
257 TEST_F(GetNavigationPolicyTest, NotResizableForcesPopup) 257 TEST_F(GetNavigationPolicyTest, NotResizableForcesPopup)
258 { 258 {
259 m_chromeClientImpl->setResizable(false); 259 m_chromeClientImpl->setResizable(false);
260 EXPECT_TRUE(isNavigationPolicyPopup()); 260 EXPECT_TRUE(isNavigationPolicyPopup());
261 m_chromeClientImpl->setResizable(true); 261 m_chromeClientImpl->setResizable(true);
262 EXPECT_FALSE(isNavigationPolicyPopup()); 262 EXPECT_FALSE(isNavigationPolicyPopup());
263 } 263 }
264 264
265 } // namespace blink 265 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698