Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1442753004: [sql] Validate database files before enabling memory-mapping. (Closed)

Created:
5 years, 1 month ago by Scott Hess - ex-Googler
Modified:
5 years, 1 month ago
Reviewers:
rmcilroy, isherman+reviewer
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sql] Validate database files before enabling memory-mapping. With regular I/O, filesystem corruption would cause SQLite to return SQLITE_IOERR codes. With memory-mapping, filesystem errors can cause a crash when accessed. There are databases with filesystem corruption, this CL only enables memory-mapped I/O for parts of the database which have been successfully read at some point using regular I/O. [Relands https://codereview.chromium.org/1426743006 which was reverted at https://codereview.chromium.org/1432953002 . CL is identical, fix to sql::Connection was landed at https://codereview.chromium.org/1426743006 .] BUG=537742 TBR=rmcilroy@chromium.org, isherman+reviewer@chromium.org Committed: https://crrev.com/d90aeea87619c019f8b4be171b65476748868ece Cr-Commit-Position: refs/heads/master@{#359478}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -8 lines) Patch
M sql/connection.h View 2 chunks +23 lines, -0 lines 0 comments Download
M sql/connection.cc View 3 chunks +148 lines, -8 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Scott Hess - ex-Googler
TBR because this CL is identical to the earlier: https://codereview.chromium.org/1426743006 Sheriffs (or bystanders), the previous ...
5 years, 1 month ago (2015-11-13 01:08:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1442753004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1442753004/1
5 years, 1 month ago (2015-11-13 01:14:05 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-13 02:24:44 UTC) #4
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 02:25:38 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d90aeea87619c019f8b4be171b65476748868ece
Cr-Commit-Position: refs/heads/master@{#359478}

Powered by Google App Engine
This is Rietveld 408576698