Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Issue 1432953002: Revert "[sql] Validate database files before enabling memory-mapping." (Closed)

Created:
5 years, 1 month ago by robliao
Modified:
5 years, 1 month ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "[sql] Validate database files before enabling memory-mapping." This reverts commit de8784cf209f5c254f6c65718373985eb662b36f. Reason for Revert: Implicated in test failures: ChromeMainTest.ReuseBrowserInstanceWhenOpeningFile ChromeMainTest.SecondLaunch ChromeMainTest.SecondLaunchFromIncognitoWithNormalUrl DiagnosticsControllerTest.RecoverFromNssCertDbFailure DiagnosticsControllerTest.RecoverFromNssKeyDbFailure First failing bot: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/8908 Original Issue: https://codereview.chromium.org/1426743006 TBR=shess@chromium.org, isherman@chromium.org, rmcilroy@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=537742 Committed: https://crrev.com/1736cd0fb260d29ac0df3f05a092b99f7933bf07 Cr-Commit-Position: refs/heads/master@{#358709}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -198 lines) Patch
M sql/connection.h View 2 chunks +0 lines, -23 lines 0 comments Download
M sql/connection.cc View 3 chunks +8 lines, -148 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
robliao
5 years, 1 month ago (2015-11-10 00:08:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1432953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1432953002/1
5 years, 1 month ago (2015-11-10 00:10:33 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-10 00:13:34 UTC) #4
Scott Hess - ex-Googler
LGTM. Can't see how this fails there with that error but it doesn't fail in ...
5 years, 1 month ago (2015-11-10 00:14:25 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 00:14:57 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1736cd0fb260d29ac0df3f05a092b99f7933bf07
Cr-Commit-Position: refs/heads/master@{#358709}

Powered by Google App Engine
This is Rietveld 408576698