[sql] Differentiate compile errors from regular errors.

[sql] Differentiate compile errors from regular errors.

GetUniqueStatement() and GetUntrackedStatement() attempt to be
pedantic about errors preparing statements, because often those errors
indicate either a syntax error in the SQL being prepared, or an error
with the database schema it is being prepared against.  That makes
testing code against various other problems like corruption
challenging.  This change attempts to restrict the flagged errors to
include fewer errors unrelated to the form of the SQL statement (or
schema).

Additionally, slightly improve the debug output for OnSqliteError()
for databases which haven't been tagged.

BUG=537742
Committed: https://crrev.com/f7e988ff06ac6ca527bc907410e1f6292534de89
Cr-Commit-Position: refs/heads/master@{#359452}

[Scott Hess - ex-Googler, 2015-11-12 01:17:50]

Description was changed from

==========
[sql] Differentiate compile errors from regular errors.

GetUniqueStatement() and GetUntrackedStatement() attempt to be
pedantic about errors preparing statements, because often those errors
indicate either a syntax error in the SQL being prepared, or an error
with the database schema it is being prepared against.  That makes
testing code against various other problems like corruption
challenging.  This change attempts to restrict the flagged errors to
include fewer errors unrelated to the form of the SQL statement (or
schema).

Additionally, slightly improve the debug output for OnSqliteError()
for databases which haven't been tagged.

BUG=none
==========

to

==========
[sql] Differentiate compile errors from regular errors.

GetUniqueStatement() and GetUntrackedStatement() attempt to be
pedantic about errors preparing statements, because often those errors
indicate either a syntax error in the SQL being prepared, or an error
with the database schema it is being prepared against.  That makes
testing code against various other problems like corruption
challenging.  This change attempts to restrict the flagged errors to
include fewer errors unrelated to the form of the SQL statement (or
schema).

Additionally, slightly improve the debug output for OnSqliteError()
for databases which haven't been tagged.

BUG=537742
==========

[Scott Hess - ex-Googler, 2015-11-12 01:23:20]

shess@chromium.org changed reviewers:
+ michaeln@chromium.org

[Scott Hess - ex-Googler, 2015-11-12 01:23:20]

https://codereview.chromium.org/1432953002 reverted my change
https://codereview.chromium.org/1426743006

My change caused DiagnosticsControllerTest tests RecoverFromNssCertDbFailure and
RecoverFromNssKeyDbFailure to fail because they intentionally create a corrupt
database and my change adds additional queries during Open().

My change caused ChromeMainTest tests ReuseBrowserInstanceWhenOpeningFile,
SecondLaunch and SecondLaunchFromIncognitoWithNormalUrl to fail in a new way. 
They were already failing (see http://crbug.com/554715 ), but the existing
failures all got routed to an error callback and ignored.  I think having these
not be that kind of failure in the first place is more reasonable.

[Scott Hess - ex-Googler, 2015-11-12 01:23:27]

The CQ bit was checked by shess@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-12 01:25:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1434173003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1434173003/1

[commit-bot: I haz the power, 2015-11-12 02:59:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-12 02:59:03]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Scott Hess - ex-Googler, 2015-11-12 20:15:00]

On 2015/11/12 01:23:20, Scott Hess wrote:
> https://codereview.chromium.org/1432953002 reverted my change
> https://codereview.chromium.org/1426743006
> 
> My change caused DiagnosticsControllerTest tests RecoverFromNssCertDbFailure
and
> RecoverFromNssKeyDbFailure to fail because they intentionally create a corrupt
> database and my change adds additional queries during Open().
> 
> My change caused ChromeMainTest tests ReuseBrowserInstanceWhenOpeningFile,
> SecondLaunch and SecondLaunchFromIncognitoWithNormalUrl to fail in a new way. 
> They were already failing (see http://crbug.com/554715 ), but the existing
> failures all got routed to an error callback and ignored.  I think having
these
> not be that kind of failure in the first place is more reasonable.

Ping?  I'm hoping to re-land the reverted CL today so it gets into the canary.

AFAICT the win_chromium_rel_ng fail is unrelated to my CL.

Thanks,
scott

[michaeln, 2015-11-13 00:03:54]

lgtm

lgtm

[Scott Hess - ex-Googler, 2015-11-13 00:10:06]

The CQ bit was checked by shess@chromium.org

[Scott Hess - ex-Googler, 2015-11-13 00:10:15]

On 2015/11/13 00:03:54, michaeln wrote:
> lgtm
> 
> lgtm

Thanks!

Thanks!

[commit-bot: I haz the power, 2015-11-13 00:12:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1434173003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1434173003/1

[commit-bot: I haz the power, 2015-11-13 00:41:15]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-11-13 00:42:23]

Patchset 1 (id:??) landed as
https://crrev.com/f7e988ff06ac6ca527bc907410e1f6292534de89
Cr-Commit-Position: refs/heads/master@{#359452}