Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1441993004: Hide PrivetHttpClient inside of PrivetV3Session (Closed)

Created:
5 years, 1 month ago by Vitaly Buka (NO REVIEWS)
Modified:
5 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@context4
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hide PrivetHttpClient inside of PrivetV3Session and use real one instead Mock in unittests. BUG=551631, 524788 Committed: https://crrev.com/42b71e27f764f52137c5754433b066f507c79ed7 Cr-Commit-Position: refs/heads/master@{#359766}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -76 lines) Patch
M chrome/browser/extensions/api/gcd_private/gcd_private_api.cc View 4 chunks +8 lines, -14 lines 0 comments Download
M chrome/browser/extensions/api/gcd_private/privet_v3_session.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/gcd_private/privet_v3_session.cc View 3 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/gcd_private/privet_v3_session_unittest.cc View 7 chunks +16 lines, -56 lines 0 comments Download
M chrome/browser/local_discovery/privet_url_fetcher.h View 1 chunk +6 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 16 (8 generated)
Vitaly Buka (NO REVIEWS)
5 years, 1 month ago (2015-11-13 23:58:02 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1441993004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1441993004/1
5 years, 1 month ago (2015-11-13 23:59:21 UTC) #6
Aleksey Shlyapnikov
lgtm
5 years, 1 month ago (2015-11-14 00:12:41 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/130851)
5 years, 1 month ago (2015-11-14 00:35:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1441993004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1441993004/1
5 years, 1 month ago (2015-11-14 01:46:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1441993004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1441993004/1
5 years, 1 month ago (2015-11-15 02:38:47 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-15 03:46:39 UTC) #15
commit-bot: I haz the power
5 years, 1 month ago (2015-11-15 03:47:22 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/42b71e27f764f52137c5754433b066f507c79ed7
Cr-Commit-Position: refs/heads/master@{#359766}

Powered by Google App Engine
This is Rietveld 408576698