Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1441403005: Use shared shared URLRequestContextGetter for all gcd_private sessions (Closed)

Created:
5 years, 1 month ago by Vitaly Buka (NO REVIEWS)
Modified:
5 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@context5
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use shared shared URLRequestContextGetter for all gcd_private sessions PrivetV3ContextGetter is context getter for gcd_private sessions. It's owned by singleton of GcdPrivateAPIImpl. BUG=524788 Committed: https://crrev.com/60701c6012a69ffab8b2fe8b9f19e98469c1fc40 Cr-Commit-Position: refs/heads/master@{#359782}

Patch Set 1 #

Patch Set 2 : #

Messages

Total messages: 20 (9 generated)
Vitaly Buka (NO REVIEWS)
5 years, 1 month ago (2015-11-14 01:56:05 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1441403005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1441403005/1
5 years, 1 month ago (2015-11-14 01:56:38 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/140784)
5 years, 1 month ago (2015-11-14 02:20:03 UTC) #6
Aleksey Shlyapnikov
lgtm
5 years, 1 month ago (2015-11-14 02:22:37 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1441403005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1441403005/1
5 years, 1 month ago (2015-11-15 03:10:31 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/140921)
5 years, 1 month ago (2015-11-15 03:31:35 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1441403005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1441403005/20001
5 years, 1 month ago (2015-11-15 06:27:09 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-15 12:11:02 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1441403005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1441403005/20001
5 years, 1 month ago (2015-11-15 19:45:20 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-15 19:48:59 UTC) #19
commit-bot: I haz the power
5 years, 1 month ago (2015-11-15 19:49:48 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/60701c6012a69ffab8b2fe8b9f19e98469c1fc40
Cr-Commit-Position: refs/heads/master@{#359782}

Powered by Google App Engine
This is Rietveld 408576698