Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1434383004: Don't use PrivetHTTPAsynchronousFactory in PrivetV3Session (Closed)

Created:
5 years, 1 month ago by Vitaly Buka (NO REVIEWS)
Modified:
5 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@context3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't use PrivetHTTPAsynchronousFactory in PrivetV3Session BUG=551631, 524788 Committed: https://crrev.com/1283eca15bd9f772387f75241576cde7bdec7f54 Cr-Commit-Position: refs/heads/master@{#359700}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -16 lines) Patch
M chrome/browser/extensions/api/gcd_private/gcd_private_api.cc View 1 3 chunks +19 lines, -16 lines 0 comments Download

Depends on Patchset:

Issue 1442923002 Patch 40001

Dependent Patchsets:

Issue 1441993004 Patch 1

Messages

Total messages: 15 (7 generated)
Vitaly Buka (NO REVIEWS)
5 years, 1 month ago (2015-11-13 20:25:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1434383004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1434383004/20001
5 years, 1 month ago (2015-11-13 23:11:59 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 1 month ago (2015-11-13 23:12:02 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1434383004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1434383004/20001
5 years, 1 month ago (2015-11-13 23:14:03 UTC) #9
Aleksey Shlyapnikov
lgtm
5 years, 1 month ago (2015-11-13 23:16:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1434383004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1434383004/20001
5 years, 1 month ago (2015-11-13 23:18:20 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-14 00:16:23 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-11-14 00:17:14 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1283eca15bd9f772387f75241576cde7bdec7f54
Cr-Commit-Position: refs/heads/master@{#359700}

Powered by Google App Engine
This is Rietveld 408576698