Issue 1441853005: Revert "Register super field set explicitly in the universe."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1441853005: Revert "Register super field set explicitly in the universe." (Closed)

Created:
5 years, 1 month ago by sra1

Modified:
5 years, 1 month ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Revert "Register super field set explicitly in the universe." Havlak benchmark tanked to 1/3. There are a lot of crashes, e.g python tools/test.py -mrelease -cdart2js -rd8 -aia32 --use-sdk --write-debug-log --write-test-outcome-log --clear_browser_cache --checked --dart2js-batch --host-checked -t1920 dart2js_native/native_class_with_dart_methods_frog_test python tools/test.py -mrelease -cdart2js -rd8 -aia32 --use-sdk --write-debug-log --write-test-outcome-log --clear_browser_cache --checked --dart2js-batch -t120 co19/LibTest/html/IFrameElement/insertBefore_A01_t01 TBR=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/2b30d5919a2a19708399828ee1a471df78a1e3fc

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -48 lines)			Patch
M	pkg/compiler/lib/src/enqueue.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/resolution/members.dart	View	3 chunks	+8 lines, -17 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/codegen.dart	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	pkg/compiler/lib/src/universe/universe.dart	View	3 chunks	+2 lines, -6 lines	0 comments	Download
M	pkg/compiler/lib/src/universe/use.dart	View	2 chunks	+4 lines, -14 lines	0 comments	Download
M	pkg/compiler/lib/src/world.dart	View	1 chunk	+4 lines, -7 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

sra1

5 years, 1 month ago (2015-11-14 01:15:42 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2b30d5919a2a19708399828ee1a471df78a1e3fc (presubmit successful).

Expand Messages | Collapse Messages