Revert "Register super field set explicitly in the universe."

pkg/compiler/lib/src/universe/use.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// This library defined `uses`. A `use` is a single impact of the world, for
 /// instance an invocation of a top level function or a call to the `foo()`
 /// method on an unknown class.
 library dart2js.universe.use;
 
 import '../closure.dart' show
@@ skipping 52 matching lines @@
     return selector == other.selector && mask == other.mask;
   }
 
   String toString() => '$selector,$mask';
 }
 
 enum StaticUseKind {
   GENERAL,
   STATIC_TEAR_OFF,
   SUPER_TEAR_OFF,
-  SUPER_FIELD_SET,
   FIELD_GET,
   FIELD_SET,
   CLOSURE,
 }
 
 /// Statically known use of an [Element].
 // TODO(johnniwinther): Create backend-specific implementations with better
 // invariants.
 class StaticUse {
   final Element element;
@@ skipping 70 matching lines @@
 
   /// Read access of a super field or getter [element].
   factory StaticUse.superGet(MemberElement element) {
     assert(invariant(element, element.isInstanceMember,
         message: "Super get element $element must be an instance method."));
     assert(invariant(element, element.isField || element.isGetter,
         message: "Super get element $element must be a field or a getter."));
     return new StaticUse._(element, StaticUseKind.GENERAL);
   }
 
-  /// Write access of a super field [element].
-  factory StaticUse.superFieldSet(FieldElement element) {
+  /// Write access of a super field or setter [element].
+  factory StaticUse.superSet(Element element) {
     assert(invariant(element, element.isInstanceMember,
         message: "Super set element $element must be an instance method."));
-    assert(invariant(element, element.isField,
-        message: "Super set element $element must be a field."));
-    return new StaticUse._(element, StaticUseKind.SUPER_FIELD_SET);
-  }
-
-  /// Write access of a super setter [element].
-  factory StaticUse.superSetterSet(SetterElement element) {
-    assert(invariant(element, element.isInstanceMember,
-        message: "Super set element $element must be an instance method."));
-    assert(invariant(element, element.isSetter,
-        message: "Super set element $element must be a setter."));
+    assert(invariant(element, element.isField || element.isSetter,
+        message: "Super set element $element must be a field or a setter."));
     return new StaticUse._(element, StaticUseKind.GENERAL);
   }
 
   /// Closurization of a super method [element].
   factory StaticUse.superTearOff(MethodElement element) {
     assert(invariant(element, element.isInstanceMember && element.isFunction,
         message: "Super invoke element $element must be an instance method."));
     return new StaticUse._(element, StaticUseKind.SUPER_TEAR_OFF);
   }
 
@@ skipping 127 matching lines @@
 
   bool operator ==(other) {
     if (identical(this, other)) return true;
     if (other is! TypeUse) return false;
     return type == other.type &&
            kind == other.kind;
   }
 
   String toString() => 'TypeUse($type,$kind)';
 }