Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Side by Side Diff: pkg/compiler/lib/src/ssa/codegen.dart

Issue 1441853005: Revert "Register super field set explicitly in the universe." (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of ssa; 5 part of ssa;
6 6
7 class SsaCodeGeneratorTask extends CompilerTask { 7 class SsaCodeGeneratorTask extends CompilerTask {
8 8
9 final JavaScriptBackend backend; 9 final JavaScriptBackend backend;
10 final SourceInformationStrategy sourceInformationFactory; 10 final SourceInformationStrategy sourceInformationFactory;
(...skipping 1733 matching lines...) Expand 10 before | Expand all | Expand 10 after
1744 ClassElement superClass = superElement.enclosingClass; 1744 ClassElement superClass = superElement.enclosingClass;
1745 if (superElement.isField) { 1745 if (superElement.isField) {
1746 js.Name fieldName = 1746 js.Name fieldName =
1747 backend.namer.instanceFieldPropertyName(superElement); 1747 backend.namer.instanceFieldPropertyName(superElement);
1748 use(node.inputs[0]); 1748 use(node.inputs[0]);
1749 js.PropertyAccess access = 1749 js.PropertyAccess access =
1750 new js.PropertyAccess(pop(), fieldName) 1750 new js.PropertyAccess(pop(), fieldName)
1751 .withSourceInformation(node.sourceInformation); 1751 .withSourceInformation(node.sourceInformation);
1752 if (node.isSetter) { 1752 if (node.isSetter) {
1753 registry.registerStaticUse( 1753 registry.registerStaticUse(
1754 superElement.isSetter 1754 new StaticUse.superSet(superElement));
1755 ? new StaticUse.superSetterSet(superElement)
1756 : new StaticUse.superFieldSet(superElement));
1757 use(node.value); 1755 use(node.value);
1758 push(new js.Assignment(access, pop()) 1756 push(new js.Assignment(access, pop())
1759 .withSourceInformation(node.sourceInformation)); 1757 .withSourceInformation(node.sourceInformation));
1760 } else { 1758 } else {
1761 registry.registerStaticUse(new StaticUse.superGet(superElement)); 1759 registry.registerStaticUse(new StaticUse.superGet(superElement));
1762 push(access); 1760 push(access);
1763 } 1761 }
1764 } else { 1762 } else {
1765 Selector selector = node.selector; 1763 Selector selector = node.selector;
1766 if (!backend.maybeRegisterAliasedSuperMember(superElement, selector)) { 1764 if (!backend.maybeRegisterAliasedSuperMember(superElement, selector)) {
(...skipping 1144 matching lines...) Expand 10 before | Expand all | Expand 10 after
2911 new StaticUse.staticInvoke(helper, 2909 new StaticUse.staticInvoke(helper,
2912 new CallStructure.unnamed(argumentCount))); 2910 new CallStructure.unnamed(argumentCount)));
2913 return backend.emitter.staticFunctionAccess(helper); 2911 return backend.emitter.staticFunctionAccess(helper);
2914 } 2912 }
2915 2913
2916 @override 2914 @override
2917 void visitRef(HRef node) { 2915 void visitRef(HRef node) {
2918 visit(node.value); 2916 visit(node.value);
2919 } 2917 }
2920 } 2918 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/resolution/members.dart ('k') | pkg/compiler/lib/src/universe/universe.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698