Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 1441853002: Web Animations: Add SVGPathInterpolationType (Closed)

Created:
5 years, 1 month ago by alancutter (OOO until 2018)
Modified:
5 years ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@_svgNumberListInterpolationType
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Web Animations: Add SVGPathInterpolationType This change migrates animations on the d SVG attribute over to SVGPathInterpolationType and enables neutral keyframes. d attribute animations don't have additive compositing behaviour, Web Animations correctly replaces if the user specifies "add" while SMIL produces corrupt output. This is a continuation of: https://codereview.chromium.org/1413463008 BUG=530436 Committed: https://crrev.com/8027b17696534a971f2e7f9a43197a2a6347bb6f Cr-Commit-Position: refs/heads/master@{#365746}

Patch Set 1 #

Patch Set 2 : Actually upload #

Patch Set 3 : Responsive #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+809 lines, -516 lines) Patch
A third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-d-composition.html View 1 1 chunk +108 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-d-composition-expected.txt View 1 1 chunk +61 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-d-interpolation.html View 1 8 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-d-interpolation-expected.txt View 1 1 chunk +16 lines, -16 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/svg-attribute-responsive/svg-d-responsive.html View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/animation/InterpolatedSVGPathSource.h View 1 1 chunk +55 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/core/animation/PathSVGInterpolation.h View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/Source/core/animation/PathSVGInterpolation.cpp View 1 2 3 1 chunk +0 lines, -446 lines 0 comments Download
A + third_party/WebKit/Source/core/animation/SVGPathInterpolationType.h View 1 2 chunks +6 lines, -6 lines 0 comments Download
A third_party/WebKit/Source/core/animation/SVGPathInterpolationType.cpp View 1 2 3 1 chunk +170 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/animation/SVGPathSegInterpolationFunctions.h View 1 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/animation/SVGPathSegInterpolationFunctions.cpp View 1 1 chunk +315 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/StringKeyframe.cpp View 1 2 3 5 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
alancutter (OOO until 2018)
5 years ago (2015-11-26 08:16:43 UTC) #4
alancutter (OOO until 2018)
On 2015/11/26 at 08:16:43, alancutter wrote: > dstockwell: Poke.
5 years ago (2015-12-10 23:07:46 UTC) #5
dstockwell
lgtm
5 years ago (2015-12-16 11:42:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1441853002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1441853002/60001
5 years ago (2015-12-17 02:35:35 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-12-17 05:22:15 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-17 05:23:12 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/8027b17696534a971f2e7f9a43197a2a6347bb6f
Cr-Commit-Position: refs/heads/master@{#365746}

Powered by Google App Engine
This is Rietveld 408576698