Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1714)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1413463008: Web Animations: Migrate SVG path interpolation to interpolation types (Closed)

Created:
5 years, 1 month ago by dstockwell
Modified:
5 years, 1 month ago
CC:
fs, darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Web Animations: Migrate SVG path interpolation to interpolation types BUG=530436

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+261 lines, -576 lines) Patch
A third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-d-composition.html View 1 chunk +101 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/resources/interpolation-test.js View 2 chunks +15 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-d-interpolation.html View 8 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-d-interpolation-expected.txt View 1 chunk +16 lines, -16 lines 0 comments Download
D third_party/WebKit/Source/core/animation/PathSVGInterpolation.h View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/Source/core/animation/PathSVGInterpolation.cpp View 1 chunk +0 lines, -449 lines 0 comments Download
M third_party/WebKit/Source/core/animation/SVGIntegerInterpolationType.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/SVGIntegerInterpolationType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/SVGInterpolationType.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/SVGInterpolationType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/SVGNumberInterpolationType.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/SVGNumberInterpolationType.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/animation/SVGPathInterpolationType.h View 1 chunk +8 lines, -6 lines 0 comments Download
A + third_party/WebKit/Source/core/animation/SVGPathInterpolationType.cpp View 3 chunks +96 lines, -36 lines 1 comment Download
M third_party/WebKit/Source/core/animation/SVGValueInterpolationType.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/StringKeyframe.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPath.h View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
dstockwell
5 years, 1 month ago (2015-11-03 05:25:21 UTC) #2
fs
5 years, 1 month ago (2015-11-03 10:03:12 UTC) #4 
https://codereview.chromium.org/1413463008/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/animation/SVGPathInterpolationType.cpp
(right):

https://codereview.chromium.org/1413463008/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/animation/SVGPathInterpolationType.cpp:492: //
TODO(ericwilligers): We shouldn't be parsing at application time.
Drive-by note: This is not really a "parsing" operation, but essentially a
copy-and-convert (InterpolableValue/List -> SVGPathByteStream). We could have
static copying methods etc. but I think we'd rather thave less than more in this
area if we can.

Powered by Google App Engine
This is Rietveld 408576698