Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1441643002: [Interpreter] Add support for global loads / stores / calls to BytecodeGraphBuilder. (Closed)

Created:
5 years, 1 month ago by rmcilroy
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@int_tf_call
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Add support for global loads / stores / calls to BytecodeGraphBuilder. Adds support for the LdaGlobal and StaGlobal bytecodes to the BytecodeGraphBuilder. Also fixes a bug in the context node's parameter index and start node inputs. BUG=v8:4280 LOG=N

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review comments #

Patch Set 3 : Move unittest to bytcodearraybuilder #

Unified diffs Side-by-side diffs Delta from patch set Stats (+350 lines, -24 lines) Patch
M src/compiler/bytecode-graph-builder.h View 1 chunk +6 lines, -5 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 3 chunks +58 lines, -16 lines 0 comments Download
M src/objects.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-run-bytecode-graph-builder.cc View 1 2 2 chunks +48 lines, -0 lines 0 comments Download
M test/unittests/compiler/bytecode-graph-builder-unittest.cc View 1 2 5 chunks +94 lines, -2 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 2 3 chunks +132 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1437873002 Patch 40001

Dependent Patchsets:

Issue 1435423002 Patch 1

Messages

Total messages: 8 (2 generated)
rmcilroy
Benedikt, Orion, Mythri, PTAL, thanks.
5 years, 1 month ago (2015-11-12 12:21:40 UTC) #3
oth
lgtm lgtm https://codereview.chromium.org/1441643002/diff/1/test/cctest/compiler/test-run-bytecode-graph-builder.cc File test/cctest/compiler/test-run-bytecode-graph-builder.cc (right): https://codereview.chromium.org/1441643002/diff/1/test/cctest/compiler/test-run-bytecode-graph-builder.cc#newcode160 test/cctest/compiler/test-run-bytecode-graph-builder.cc:160: DCHECK_LT(i, N); Probably best to bounds checking ...
5 years, 1 month ago (2015-11-12 12:35:21 UTC) #4
rmcilroy
https://codereview.chromium.org/1441643002/diff/1/test/cctest/compiler/test-run-bytecode-graph-builder.cc File test/cctest/compiler/test-run-bytecode-graph-builder.cc (right): https://codereview.chromium.org/1441643002/diff/1/test/cctest/compiler/test-run-bytecode-graph-builder.cc#newcode160 test/cctest/compiler/test-run-bytecode-graph-builder.cc:160: DCHECK_LT(i, N); On 2015/11/12 12:35:21, oth wrote: > Probably ...
5 years, 1 month ago (2015-11-12 13:02:47 UTC) #5
Benedikt Meurer
LGTM from my side.
5 years, 1 month ago (2015-11-12 13:19:50 UTC) #6
mythria
lgtm
5 years, 1 month ago (2015-11-12 13:20:16 UTC) #7
oth
5 years, 1 month ago (2015-11-17 10:36:51 UTC) #8 
On 2015/11/12 13:20:16, mythria wrote:
> lgtm

Moving to a new CL to land on behalf of Ross:
https://codereview.chromium.org/1449373002/
--

Powered by Google App Engine
This is Rietveld 408576698