Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1435423002: [Interpreter] Add New, CallRuntime and CallJSRuntime support to BytecodeGraphBuilder. (Closed)

Created:
5 years, 1 month ago by rmcilroy
Modified:
5 years, 1 month ago
Reviewers:
oth
CC:
v8-reviews_googlegroups.com, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@int_tf_globals
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Add New, CallRuntime and CallJSRuntime support to BytecodeGraphBuilder. Adds support for the New, CallRuntime and CallJSRuntime bytecodes in BytecodeGraphBuilder. Also adds BuildLoadObjectField, BuildLoadGlobalObject and BuildLoadNativeContextField helpers. BUG=v8:4280 LOG=N

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -13 lines) Patch
M src/compiler/bytecode-graph-builder.h View 2 chunks +15 lines, -3 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 5 chunks +86 lines, -8 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-run-bytecode-graph-builder.cc View 3 chunks +70 lines, -1 line 0 comments Download
M test/unittests/compiler/bytecode-graph-builder-unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1441643002 Patch 40001

Messages

Total messages: 4 (2 generated)
oth
Moved to a new CL so this can be landed on behalf of rmcilroy: https://codereview.chromium.org/1449373002 ...
5 years, 1 month ago (2015-11-17 10:54:16 UTC) #2
oth
5 years, 1 month ago (2015-11-17 10:57:18 UTC) #4
Message was sent while issue was closed. 
On 2015/11/17 10:54:16, oth wrote:
> Moved to a new CL so this can be landed on behalf of rmcilroy:
> 
> https://codereview.chromium.org/1449373002
> 
> ---

Correction, moved to:

https://codereview.chromium.org/1456483002

Powered by Google App Engine
This is Rietveld 408576698