Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 1441533003: Update testing frameworks/tests for MDB (Closed)

Created:
5 years, 1 month ago by robertphillips
Modified:
5 years, 1 month ago
Reviewers:
joshualitt, joshua.litt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update testing frameworks/tests for MDB This CL: Fixes an ordering problem w.r.t. drawTarget clean up in GrContext::abandonContext (for text test that abandons context) Fixes when the lastDrawTarget field is set on a RenderTarget (now in GrDrawTarget ctor) due to GrTestTarget use case Updates the ProgramUnitTest to use multiple drawTargets Adds renderTarget creation to GrTestTargets (in MDB drawTargets require them) BUG=skia:4094 Committed: https://skia.googlesource.com/skia/+/9c8605144a0f15e3e69a4e1dcd5d3e63f339380e Committed: https://skia.googlesource.com/skia/+/0dfa62c97707ac9b0fc0bdba7acfc8405db5c836

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : Free the draw targets (in the MDB case) #

Total comments: 2

Patch Set 4 : Added comment #

Patch Set 5 : Fix ref counting bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -22 lines) Patch
M src/gpu/GrContext.cpp View 1 2 3 1 chunk +5 lines, -2 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrDrawingManager.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawingManager.cpp View 1 2 3 3 chunks +17 lines, -4 lines 0 comments Download
M src/gpu/GrTest.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/GrTest.cpp View 1 2 3 4 2 chunks +18 lines, -3 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 2 3 4 4 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 24 (12 generated)
robertphillips
5 years, 1 month ago (2015-11-12 18:34:59 UTC) #3
joshualitt
lgtm, minor question https://codereview.chromium.org/1441533003/diff/40001/src/gpu/GrContext.cpp File src/gpu/GrContext.cpp (right): https://codereview.chromium.org/1441533003/diff/40001/src/gpu/GrContext.cpp#newcode122 src/gpu/GrContext.cpp:122: fDrawingManager->abandon(); if moving this is intentional, ...
5 years, 1 month ago (2015-11-12 20:48:55 UTC) #5
robertphillips
https://codereview.chromium.org/1441533003/diff/40001/src/gpu/GrContext.cpp File src/gpu/GrContext.cpp (right): https://codereview.chromium.org/1441533003/diff/40001/src/gpu/GrContext.cpp#newcode122 src/gpu/GrContext.cpp:122: fDrawingManager->abandon(); On 2015/11/12 20:48:55, joshualitt wrote: > if moving ...
5 years, 1 month ago (2015-11-13 12:41:40 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1441533003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1441533003/60001
5 years, 1 month ago (2015-11-13 12:41:58 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-13 12:53:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1441533003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1441533003/60001
5 years, 1 month ago (2015-11-13 14:05:29 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/9c8605144a0f15e3e69a4e1dcd5d3e63f339380e
5 years, 1 month ago (2015-11-13 14:06:07 UTC) #14
egdaniel
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/1450513002/ by egdaniel@google.com. ...
5 years, 1 month ago (2015-11-13 21:42:31 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1441533003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1441533003/80001
5 years, 1 month ago (2015-11-16 14:11:04 UTC) #18
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-16 14:22:35 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1441533003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1441533003/80001
5 years, 1 month ago (2015-11-16 14:22:56 UTC) #23
commit-bot: I haz the power
5 years, 1 month ago (2015-11-16 14:23:35 UTC) #24
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/0dfa62c97707ac9b0fc0bdba7acfc8405db5c836

Powered by Google App Engine
This is Rietveld 408576698