Object's body descriptors refactoring.

Object's body descriptors refactoring.

1) Body descriptors moved to their own header files.
2) Missing body descriptors added.
3) Template versions of HeapObject::Iterate*() methods added.
4) Body descriptors support new kind of queries: IsValidSlot(offset) which can be used for invalid slots filtering.

This is a first step towards virtual and static visitors unification and support in-object properties in built-in (sub-)classes.

Committed: https://crrev.com/138eb324ea2cd367b2252d199b3b81b18f7b10d5
Cr-Commit-Position: refs/heads/master@{#31980}

[Igor Sheludko, 2015-11-13 08:30:28]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2015-11-13 08:33:07]

Description was changed from

==========
Body descriptors refactoring.

1) Body descriptors moved to their own header files.
2) Missing body descriptors added.
3) Template versions of HeapObject::Iterate*() methods added.
4) Body descriptors support new kind of queries: IsPointerField(offset) which
can then be used for invalid slots filtering.
==========

to

==========
Object's body descriptors refactoring.

1) Body descriptors moved to their own header files.
2) Missing body descriptors added.
3) Template versions of HeapObject::Iterate*() methods added.
4) Body descriptors support new kind of queries: IsPointerField(offset) which
can then be used for invalid slots filtering.

This is a first step towards virtual and static visitors unification and support
in-object properties in built-in (sub-)classes.
==========

[Igor Sheludko, 2015-11-13 09:15:38]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-13 09:15:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1440243002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1440243002/20001

[Igor Sheludko, 2015-11-13 09:16:27]

Patchset #1 (id:20001) has been deleted

[Igor Sheludko, 2015-11-13 09:29:55]

Description was changed from

==========
Object's body descriptors refactoring.

1) Body descriptors moved to their own header files.
2) Missing body descriptors added.
3) Template versions of HeapObject::Iterate*() methods added.
4) Body descriptors support new kind of queries: IsPointerField(offset) which
can then be used for invalid slots filtering.

This is a first step towards virtual and static visitors unification and support
in-object properties in built-in (sub-)classes.
==========

to

==========
Object's body descriptors refactoring.

1) Body descriptors moved to their own header files.
2) Missing body descriptors added.
3) Template versions of HeapObject::Iterate*() methods added.
4) Body descriptors support new kind of queries: IsValidSlot(offset) which can
be used for invalid slots filtering.

This is a first step towards virtual and static visitors unification and support
in-object properties in built-in (sub-)classes.
==========

[Igor Sheludko, 2015-11-13 09:34:26]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-13 09:34:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1440243002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1440243002/60001

[Igor Sheludko, 2015-11-13 09:40:51]

ishell@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Igor Sheludko, 2015-11-13 09:40:51]

PTAL

[commit-bot: I haz the power, 2015-11-13 09:52:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-13 09:52:47]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2015-11-13 10:58:54]

https://codereview.chromium.org/1440243002/diff/60001/src/heap/objects-visiti...
File src/heap/objects-visiting-inl.h (right):

https://codereview.chromium.org/1440243002/diff/60001/src/heap/objects-visiti...
src/heap/objects-visiting-inl.h:443: typedef FlexibleBodyVisitor<StaticVisitor,
Code::BodyDescriptor, void>
nit: Let's move the typedef to the top of the function for consistency.

https://codereview.chromium.org/1440243002/diff/60001/src/objects-body-descri...
File src/objects-body-descriptors-fwd.h (right):

https://codereview.chromium.org/1440243002/diff/60001/src/objects-body-descri...
src/objects-body-descriptors-fwd.h:5: #ifndef V8_OBJECTS_BODY_DESCRIPTORS_FWD_H_
I am not a fan of yet another family of header files. AFAICT this is only used
in objects.h for now. Would it be sufficient to have the forward declarations in
objects.h only?

[Igor Sheludko, 2015-11-13 11:18:17]

Patchset #3 (id:80001) has been deleted

[Igor Sheludko, 2015-11-13 11:23:51]

https://codereview.chromium.org/1440243002/diff/60001/src/heap/objects-visiti...
File src/heap/objects-visiting-inl.h (right):

https://codereview.chromium.org/1440243002/diff/60001/src/heap/objects-visiti...
src/heap/objects-visiting-inl.h:443: typedef FlexibleBodyVisitor<StaticVisitor,
Code::BodyDescriptor, void>
On 2015/11/13 10:58:54, Michael Starzinger wrote:
> nit: Let's move the typedef to the top of the function for consistency.

Done.

https://codereview.chromium.org/1440243002/diff/60001/src/objects-body-descri...
File src/objects-body-descriptors-fwd.h (right):

https://codereview.chromium.org/1440243002/diff/60001/src/objects-body-descri...
src/objects-body-descriptors-fwd.h:5: #ifndef V8_OBJECTS_BODY_DESCRIPTORS_FWD_H_
On 2015/11/13 10:58:54, Michael Starzinger wrote:
> I am not a fan of yet another family of header files. AFAICT this is only used
> in objects.h for now. Would it be sufficient to have the forward declarations
in
> objects.h only?

Done.

[Michael Starzinger, 2015-11-13 11:30:54]

LGTM with one final comment to address.

https://codereview.chromium.org/1440243002/diff/100001/src/objects-body-descr...
File src/objects-body-descriptors.h (right):

https://codereview.chromium.org/1440243002/diff/100001/src/objects-body-descr...
src/objects-body-descriptors.h:5: #ifndef V8_OBJECTS_BODY_DESCRIPTORS_H_
Also add the two new files to the BUILD.gn and the v8.gyp files.

[Igor Sheludko, 2015-11-13 11:37:39]

https://codereview.chromium.org/1440243002/diff/100001/src/objects-body-descr...
File src/objects-body-descriptors.h (right):

https://codereview.chromium.org/1440243002/diff/100001/src/objects-body-descr...
src/objects-body-descriptors.h:5: #ifndef V8_OBJECTS_BODY_DESCRIPTORS_H_
On 2015/11/13 11:30:54, Michael Starzinger wrote:
> Also add the two new files to the BUILD.gn and the v8.gyp files.

Done.

[Igor Sheludko, 2015-11-13 11:37:49]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-13 11:38:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1440243002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1440243002/120001

[commit-bot: I haz the power, 2015-11-13 12:22:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-13 12:22:46]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2015-11-13 12:28:58]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2015-11-13 12:28:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1440243002/#ps120001
(title: "New files added to the lists")

[commit-bot: I haz the power, 2015-11-13 12:29:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1440243002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1440243002/120001

[commit-bot: I haz the power, 2015-11-13 12:32:14]

Committed patchset #4 (id:120001)

[commit-bot: I haz the power, 2015-11-14 23:21:25]

Patchset 4 (id:??) landed as
https://crrev.com/138eb324ea2cd367b2252d199b3b81b18f7b10d5
Cr-Commit-Position: refs/heads/master@{#31980}