Issue 144023015: Revert 246678 "Use the icu data file on Linux (but not on CrOS)"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 144023015: Revert 246678 "Use the icu data file on Linux (but not on CrOS)" (Closed)

Created:
6 years, 11 months ago by Ronghua Wu (Left Chromium)

Modified:
6 years, 11 months ago

Reviewers:
jungshik at Google

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 246678 "Use the icu data file on Linux (but not on CrOS)" "Failed sizes" - http://build.chromium.org/p/chromium/builders/Linux > Use the icu data file on Linux (but not on CrOS) > > Set icu_use_data_file_flag to 1 for POSIX (other than Mac/iOS/Android). > > Mac and Android will be handled in a separate CL. > > This has to wait until https://codereview.chromium.org/111723007/ is rolled in. > (done by https://codereview.chromium.org/118313004/ ) > > BUG=72633 > TEST=All linux builds go through and all tests pass and there's no perf (start-up etc) regression. > > Review URL: https://codereview.chromium.org/102413007 TBR=jshin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246952

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+0 lines, -12 lines)			Patch
trunk/src/build/common.gypi	View	1 chunk	+0 lines, -4 lines	0 comments	Download
trunk/src/chrome/installer/linux/common/installer.include	View	1 chunk	+0 lines, -4 lines	0 comments	Download
trunk/src/chrome/tools/build/linux/FILES.cfg	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

Ronghua Wu (Left Chromium)

6 years, 11 months ago (2014-01-24 20:25:15 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r246952.