Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 118313004: Roll icu to 241739 and drop a version from icudt*dat (Closed)

Created:
7 years ago by jungshik at Google
Modified:
7 years ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, erikwright+watch_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

Roll icu to 241739 and drop a version from icudt*dat For details on icu@r=241739, see https://codereview.chromium.org/111723007/ and https://codereview.chromium.org/118373006/ They're the ICU-side of changes to enable icu_use_data_file. In addition, icudt46l.dat is renamed icudtl.dat (no version number) so that icu_util.cc has to be changed. This CL should be no-op except on iOS [1] until 3 platform specific CLs listed below are landed after this CL gets landed. Windows (https://codereview.chromium.org/99473012 ), Linux ( https://codereview.chromium.org/102413007 ) Mac ( https://codereview.chromium.org/109013004 ) [1] iOS currently has icu_use_data_file_flag=1 and the change in icu.gyp affects iOS builds. BUG=72633 TEST=All builds on all platforms go through and tests using icu data (e.g. layout tests, base_unittests:*String*, net_unittests:*IDN* ) pass. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241790

Patch Set 1 #

Total comments: 1

Patch Set 2 : roll icu to a newer version with ios fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/icu_util.cc View 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jungshik at Google
This is to roll ICU to enable icu_use_data_file. I also moved the change in icu_util.cc ...
7 years ago (2013-12-18 19:45:27 UTC) #1
Mark Mentovai
LGTM https://codereview.chromium.org/118313004/diff/1/base/i18n/icu_util.cc File base/i18n/icu_util.cc (right): https://codereview.chromium.org/118313004/diff/1/base/i18n/icu_util.cc#newcode35 base/i18n/icu_util.cc:35: // build pkg configurations, etc). 'l' stands for ...
7 years ago (2013-12-18 19:59:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jshin@chromium.org/118313004/1
7 years ago (2013-12-18 20:23:54 UTC) #3
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) base_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=111256
7 years ago (2013-12-18 21:20:07 UTC) #4
jungshik at Google
On 2013/12/18 21:20:07, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years ago (2013-12-18 21:41:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jshin@chromium.org/118313004/20001
7 years ago (2013-12-19 01:40:09 UTC) #6
commit-bot: I haz the power
7 years ago (2013-12-19 04:09:59 UTC) #7
Message was sent while issue was closed.
Change committed as 241790

Powered by Google App Engine
This is Rietveld 408576698