Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: trunk/src/build/common.gypi

Issue 144023015: Revert 246678 "Use the icu data file on Linux (but not on CrOS)" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | trunk/src/chrome/installer/linux/common/installer.include » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/build/common.gypi
===================================================================
--- trunk/src/build/common.gypi (revision 246950)
+++ trunk/src/build/common.gypi (working copy)
@@ -1307,10 +1307,6 @@
# can use breakpad for these builds.
'release_unwind_tables%': 0,
}],
- # TODO(jungshik): Turn this on on Android and CrOS as well.
- ['OS!="android" and chromeos==0', {
- 'icu_use_data_file_flag%': 1,
- }],
],
}], # os_posix==1 and OS!="mac" and OS!="ios"
['OS=="ios"', {
« no previous file with comments | « no previous file | trunk/src/chrome/installer/linux/common/installer.include » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698