Issue 14401006: Revert 195482 "Make DriveSystemService an observer of DriveNotif..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14401006: Revert 195482 "Make DriveSystemService an observer of DriveNotif..." (Closed)

Created:
7 years, 8 months ago by bartfab (slow)

Modified:
7 years, 8 months ago

Reviewers:
calvinlo

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 195482 "Make DriveSystemService an observer of DriveNotif..." This broke interactive_ui_tests on the Linux Chromium OS bots. > Make DriveSystemService an observer of DriveNotificationManager so that it no longer has to handle registering for Drive XMPP notifications itself. This will also allow both SyncFileSystem and the ChromeOS Filemanager (and possibly more observers) to use XMPP notifications solving the problem from before where the same XMPP Invalidation ID was being registered twice. > > Also removed polling code from SyncFS it's OKed to remove by both SyncFS and ChromeOS teams. > > BUG=173339 > > Review URL: https://codereview.chromium.org/13891016 TBR=calvinlo@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195488

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+216 lines, -62 lines)			Patch
M	trunk/src/chrome/browser/chromeos/drive/drive_system_service.h	View	5 chunks	+15 lines, -7 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/drive/drive_system_service.cc	View	9 chunks	+61 lines, -15 lines	0 comments	Download
M	trunk/src/chrome/browser/google_apis/drive_notification_manager.h	View	2 chunks	+9 lines, -5 lines	0 comments	Download
M	trunk/src/chrome/browser/google_apis/drive_notification_manager.cc	View	5 chunks	+37 lines, -19 lines	0 comments	Download
M	trunk/src/chrome/browser/google_apis/drive_notification_observer.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/sync_file_system/drive_file_sync_service.h	View	4 chunks	+11 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/sync_file_system/drive_file_sync_service.cc	View	12 chunks	+77 lines, -3 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/webui/chromeos/drive_internals_ui.cc	View	2 chunks	+4 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

calvinlo

7 years, 8 months ago (2013-04-23 03:57:31 UTC) #3

Message was sent while issue was closed.

LGTM. Sorry, this really was a bug when running on ChromeOS using the testing
profile. I've made a fix and am retrying now. Thanks for finding the broken
tests and reverting my patch.

Expand Messages | Collapse Messages