Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Unified Diff: trunk/src/chrome/browser/google_apis/drive_notification_manager.h

Issue 14401006: Revert 195482 "Make DriveSystemService an observer of DriveNotif..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/google_apis/drive_notification_manager.h
===================================================================
--- trunk/src/chrome/browser/google_apis/drive_notification_manager.h (revision 195487)
+++ trunk/src/chrome/browser/google_apis/drive_notification_manager.h (working copy)
@@ -11,14 +11,15 @@
#include "sync/notifier/invalidation_handler.h"
class Profile;
-class ProfileSyncService;
namespace google_apis {
// Informs observers when they should check Google Drive for updates.
// Conditions under which updates should be searched:
// 1. XMPP invalidation is received from Google Drive.
+// TODO(calvinlo): Implement public syncer::InvalidationHandler interface.
// 2. Polling timer counts down.
+// TODO(calvinlo): Also add in backup timer.
class DriveNotificationManager
: public ProfileKeyedService,
public syncer::InvalidationHandler {
@@ -38,22 +39,25 @@
void AddObserver(DriveNotificationObserver* observer);
void RemoveObserver(DriveNotificationObserver* observer);
- // True when XMPP notifications registered and enabled. False otherwise.
- bool IsPushNotificationEnabled();
-
private:
void NotifyObserversToUpdate();
+
+ // XMPP notification related methods.
void RegisterDriveNotifications();
+ bool IsDriveNotificationSupported();
+ void SetPushNotificationEnabled(syncer::InvalidatorState state);
Profile* profile_;
- ProfileSyncService* profile_sync_service_;
ObserverList<DriveNotificationObserver> observers_;
+ // XMPP notification related variables.
// True when Drive File Sync Service is registered for Drive notifications.
bool push_notification_registered_;
// True once the first drive notification is received with OK state.
bool push_notification_enabled_;
+ // TODO(calvinlo): Polling variables to go here.
+
DISALLOW_COPY_AND_ASSIGN(DriveNotificationManager);
};

Powered by Google App Engine
This is Rietveld 408576698