Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: trunk/src/chrome/browser/sync_file_system/drive_file_sync_service.h

Issue 14401006: Revert 195482 "Make DriveSystemService an observer of DriveNotif..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/sync_file_system/drive_file_sync_service.h
===================================================================
--- trunk/src/chrome/browser/sync_file_system/drive_file_sync_service.h (revision 195487)
+++ trunk/src/chrome/browser/sync_file_system/drive_file_sync_service.h (working copy)
@@ -11,11 +11,12 @@
#include <string>
#include <vector>
-#include "base/callback.h"
+#include "base/callback_forward.h"
#include "base/memory/scoped_ptr.h"
#include "base/memory/weak_ptr.h"
#include "base/observer_list.h"
#include "base/threading/non_thread_safe.h"
+#include "base/timer.h"
#include "chrome/browser/google_apis/drive_notification_observer.h"
#include "chrome/browser/sync_file_system/drive_file_sync_client_interface.h"
#include "chrome/browser/sync_file_system/drive_metadata_store.h"
@@ -114,7 +115,7 @@
virtual void OnNetworkConnected() OVERRIDE;
// google_apis::DriveNotificationObserver implementation.
- virtual void OnNotificationReceived() OVERRIDE;
+ virtual void CheckForUpdates() OVERRIDE;
private:
friend class DriveFileSyncServiceMockTest;
@@ -427,6 +428,9 @@
google_apis::GDataErrorCode error,
scoped_ptr<google_apis::ResourceList> changes);
bool GetOriginForEntry(const google_apis::ResourceEntry& entry, GURL* origin);
+ void SchedulePolling();
+ void OnPollingTimerFired();
+ void UpdatePollingDelay(int64 new_delay_sec);
void NotifyObserversFileStatusChanged(const fileapi::FileSystemURL& url,
SyncFileStatus sync_status,
SyncAction action_taken,
@@ -488,6 +492,11 @@
// NotifyTaskDone when the task finished.
scoped_ptr<TaskToken> token_;
+ // Timer to trigger fetching changes for incremental sync.
+ base::OneShotTimer<DriveFileSyncService> polling_timer_;
+ // If polling_delay_seconds_ is negative (<0) the timer won't start.
+ int64 polling_delay_seconds_;
+
// Is set to true when there's a fair possibility that we have some
// remote changes that haven't been fetched yet.
//

Powered by Google App Engine
This is Rietveld 408576698