[turbofan] Make inlining heuristic less greedy.

[turbofan] Make inlining heuristic less greedy.

Only inline one candidate per iteration to make sure we really inline
the stuff that is called most often.

R=mstarzinger@chromium.org
BUG=v8:4493, v8:4544
LOG=n

Committed: https://crrev.com/0b0581421e242fe0e87b8bba9e1a9ba1abd853c4
Cr-Commit-Position: refs/heads/master@{#31958}

[Michael Starzinger, 2015-11-12 13:00:17]

LGTM, just a nit. Hehe, fix-points are hard. :)

https://codereview.chromium.org/1439773003/diff/1/src/compiler/js-inlining-he...
File src/compiler/js-inlining-heuristic.cc (right):

https://codereview.chromium.org/1439773003/diff/1/src/compiler/js-inlining-he...
src/compiler/js-inlining-heuristic.cc:101: if (cumulative_count_ >
FLAG_max_inlined_nodes_cumulative) return;
nit: Can we add a comment here explaining the logic behind this return and what
our expected behavior here is?

[Benedikt Meurer, 2015-11-12 13:05:40]

https://codereview.chromium.org/1439773003/diff/1/src/compiler/js-inlining-he...
File src/compiler/js-inlining-heuristic.cc (right):

https://codereview.chromium.org/1439773003/diff/1/src/compiler/js-inlining-he...
src/compiler/js-inlining-heuristic.cc:101: if (cumulative_count_ >
FLAG_max_inlined_nodes_cumulative) return;
On 2015/11/12 13:00:16, Michael Starzinger wrote:
> nit: Can we add a comment here explaining the logic behind this return and
what
> our expected behavior here is?

Done.

[Benedikt Meurer, 2015-11-12 13:05:42]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2015-11-12 13:05:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1439773003/#ps20001
(title: "Comment.")

[commit-bot: I haz the power, 2015-11-12 13:05:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1439773003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1439773003/20001

[Benedikt Meurer, 2015-11-12 13:08:27]

Description was changed from

==========
[turbofan] Make inlining heuristic less greedy.

Only inline one candidate per iteration to make sure we really inline
the stuff that is called most often.

R=mstarzinger@chromium.org
BUG=v8:4493
LOG=n
==========

to

==========
[turbofan] Make inlining heuristic less greedy.

Only inline one candidate per iteration to make sure we really inline
the stuff that is called most often.

R=mstarzinger@chromium.org
BUG=v8:4493, v8:4544
LOG=n
==========

[commit-bot: I haz the power, 2015-11-12 13:28:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-14 23:20:36]

Patchset 2 (id:??) landed as
https://crrev.com/0b0581421e242fe0e87b8bba9e1a9ba1abd853c4
Cr-Commit-Position: refs/heads/master@{#31958}