Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issue 1441573004: [turbofan] Lower JSCreate to an inline allocation in JSTypedLowering. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Lower JSCreate to an inline allocation in JSTypedLowering. This adds initial support for fast inline allocations of JSObject instances. It currently has exactly the same limitations as Crankshaft. R=mstarzinger@chromium.org BUG=v8:4544 LOG=n Committed: https://crrev.com/c4e19c7d8d8a21485bff922a9d39bbfa23ce25d3 Cr-Commit-Position: refs/heads/master@{#31957}

Patch Set 1 #

Patch Set 2 : Add unit test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -0 lines) Patch
M src/compiler/access-builder.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/access-builder.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +71 lines, -0 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 1 chunk +21 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
5 years, 1 month ago (2015-11-12 12:24:32 UTC) #1
Benedikt Meurer
Hey Michi, Here's the lowering for JSCreate we've talked about. Please take a look. Thanks, ...
5 years, 1 month ago (2015-11-12 12:31:45 UTC) #2
Michael Starzinger
LGTM. I like it. Can we haz unit test?
5 years, 1 month ago (2015-11-12 12:33:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1441573004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1441573004/20001
5 years, 1 month ago (2015-11-12 12:38:55 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-12 12:57:21 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-14 23:20:34 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c4e19c7d8d8a21485bff922a9d39bbfa23ce25d3
Cr-Commit-Position: refs/heads/master@{#31957}

Powered by Google App Engine
This is Rietveld 408576698