Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Unified Diff: src/compiler/js-inlining-heuristic.cc

Issue 1439773003: [turbofan] Make inlining heuristic less greedy. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@JSCreate
Patch Set: Comment. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/js-inlining-heuristic.cc
diff --git a/src/compiler/js-inlining-heuristic.cc b/src/compiler/js-inlining-heuristic.cc
index d8a191b6cd4354509b98229840f344ff82b9c2ae..74b872360599e4508f70eb1394bc50a533ba4c44 100644
--- a/src/compiler/js-inlining-heuristic.cc
+++ b/src/compiler/js-inlining-heuristic.cc
@@ -98,14 +98,15 @@ void JSInliningHeuristic::Finalize() {
if (candidates_.empty()) return; // Nothing to do without candidates.
if (FLAG_trace_turbo_inlining) PrintCandidates();
- while (!candidates_.empty()) {
- if (cumulative_count_ > FLAG_max_inlined_nodes_cumulative) break;
- auto i = candidates_.begin();
- Candidate const& candidate = *i;
- inliner_.ReduceJSCall(candidate.node, candidate.function);
- cumulative_count_ += candidate.function->shared()->ast_node_count();
- candidates_.erase(i);
- }
+ // We inline at most one candidate in every iteration of the fixpoint.
+ // This is to ensure that we don't consume the full inlining budget
+ // on things that aren't called very often.
+ if (cumulative_count_ > FLAG_max_inlined_nodes_cumulative) return;
+ auto i = candidates_.begin();
+ Candidate const& candidate = *i;
+ inliner_.ReduceJSCall(candidate.node, candidate.function);
+ cumulative_count_ += candidate.function->shared()->ast_node_count();
+ candidates_.erase(i);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698