Chromium Code Reviews
DescriptionNot sending QUIC packets if the send alarm is set. Behind FLAGS_respect_send_alarm
This fixes a subtle bug where we weren't always respecting priorities when writing.
I posit that if we are send limited by the sent packet manager, we expect to
resume with OnCanWrite, and resume the highest priority session. Unfortunately
right now that's not the case. When the highest priority session gets blocked
by the sent packet manager it schedules the alarm. However it's perfectly
possible that before the alarm fires, we get an incoming request, process it,
that stream checks to see if it can write, and when CanWrite checks now(), we
are past the time when the alarm should have fired (due to doing a lot of work,
busy machine, what have you) and write data for the random stream.
Merge internal change: 107380116
R=rch@chromium.org
BUG=
Patch Set 1 #
Total comments: 1
Patch Set 2 : Disable flag #
Depends on Patchset: Dependent Patchsets: Messages
Total messages: 4 (0 generated)
|
|||||||||||||||||||||||||||||||||||||