Issue 1435943002: Add client-side support of cert transparency for QUIC, gated at QUIC_VERSION_30.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1435943002: Add client-side support of cert transparency for QUIC, gated at QUIC_VERSION_30. (Closed)

Created:
5 years, 1 month ago by rjshade

Modified:
5 years, 1 month ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, ramant (doing other things)

Base URL:
https://chromium.googlesource.com/chromium/src.git@107380116

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add client-side support of cert transparency for QUIC, gated at QUIC_VERSION_30. With this change, when the negotiated version > QUIC_VERSION_29, the client indicates that it supports cert transparency in client hello, and caches the CSCT value if it exists in server's response. However, the client NEITHER demands SCT NOR verifies the received SCT (e.g., it is up to Chrome how to verify). Merge internal change: 107397642 R=rch@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : Use new argument in various places #

Patch Set 3 : Disable flag #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -35 lines)			Patch
M	net/quic/crypto/proof_test.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/crypto/proof_verifier.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	net/quic/crypto/proof_verifier_chromium.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/quic/crypto/proof_verifier_chromium.cc	View	1	4 chunks	+5 lines, -2 lines	0 comments	Download
M	net/quic/crypto/proof_verifier_chromium_test.cc	View	1	6 chunks	+6 lines, -6 lines	0 comments	Download
M	net/quic/crypto/quic_crypto_client_config.h	View	1	8 chunks	+9 lines, -0 lines	0 comments	Download
M	net/quic/crypto/quic_crypto_client_config.cc	View		18 chunks	+34 lines, -6 lines	0 comments	Download
M	net/quic/crypto/quic_crypto_client_config_test.cc	View		5 chunks	+14 lines, -11 lines	0 comments	Download
M	net/quic/quic_crypto_client_stream.cc	View		3 chunks	+7 lines, -8 lines	0 comments	Download
M	net/quic/quic_stream_factory.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/test_tools/crypto_test_utils_chromium.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/tools/quic/test_tools/quic_test_client.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	net/tools/quic/test_tools/quic_test_client.cc	View		3 chunks	+11 lines, -0 lines	0 comments	Download

Depends on Patchset:

Issue 1439653002 Patch 20001

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

5 years, 1 month ago (2015-11-11 17:54:16 UTC) #2

lgtm

rtenneti: FYI since you'll be building off of this CL.

Expand Messages | Collapse Messages