Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1437893002: Add token binding negotiation to QUIC (Closed)

Created:
5 years, 1 month ago by rjshade
Modified:
5 years, 1 month ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@107261172
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add token binding negotiation to QUIC This adds a tag (TBKP) to the SCFG and CHLO messages containing a taglist as a value of the supported token binding key parameters (P256 is currently the only supported param). This replaces the TLS token binding negotiation extension as part of the broader Token Binding spec when done over QUIC. Token binding negotiation is off by default - it must be turned on server-side in QuicCryptoServerConfig::ConfigOptions and client side in QuicCryptoClientConfig. If it is enabled, the application layer using QUIC must handle the rest of the Token Binding protocol. More information (including links to the Token Binding specs) is in this doc: https://docs.google.com/document/d/12eKfkdC7g5IGUCtghzg7Wi__qiEkY65fX09n8sjLtHg/edit?pli=1#heading=h.y8fw05yhvdsg Merge internal change: 107277639 R=rch@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -12 lines) Patch
M net/quic/crypto/crypto_handshake.h View 2 chunks +5 lines, -0 lines 0 comments Download
M net/quic/crypto/crypto_handshake.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/crypto/crypto_handshake_message.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/crypto/crypto_protocol.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/crypto/quic_crypto_client_config.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.cc View 4 chunks +35 lines, -0 lines 0 comments Download
M net/quic/quic_chromium_client_session_test.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/quic/quic_crypto_client_stream_test.cc View 4 chunks +41 lines, -2 lines 0 comments Download
M net/quic/quic_crypto_server_stream_test.cc View 2 chunks +21 lines, -1 line 0 comments Download
M net/quic/test_tools/crypto_test_utils.h View 3 chunks +18 lines, -2 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 4 chunks +15 lines, -4 lines 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 1 chunk +3 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 2 (0 generated)
rjshade
5 years, 1 month ago (2015-11-11 16:43:50 UTC) #1
Ryan Hamilton
5 years, 1 month ago (2015-11-11 17:56:54 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698