Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Issue 1439053003: MIPS64: Implemented the RoundUint64ToFloat64 TurboFan operator for x64 and arm64. (Closed)

Created:
5 years, 1 month ago by akos.palfi.imgtec
Modified:
5 years, 1 month ago
Reviewers:
titzer, ahaas, paul.l...
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Implemented the RoundUint64ToFloat64 TurboFan operator for x64 and arm64. Port 857cd4c1f0c24b8f38b0dcfe5cee5bb4407436ca BUG= Committed: https://crrev.com/01d77cc39b3f9fa41637bc7eb3c4ae862b3e78c7 Cr-Commit-Position: refs/heads/master@{#31973}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -1 line) Patch
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-codes-mips64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
paul.l...
LGTM! But please edit commit message to say MIPS64: ...
5 years, 1 month ago (2015-11-13 00:27:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1439053003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1439053003/1
5 years, 1 month ago (2015-11-13 00:30:41 UTC) #5
paul.l...
Adding reviewers, fyi ...
5 years, 1 month ago (2015-11-13 00:32:54 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-13 00:50:19 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-14 23:21:10 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/01d77cc39b3f9fa41637bc7eb3c4ae862b3e78c7
Cr-Commit-Position: refs/heads/master@{#31973}

Powered by Google App Engine
This is Rietveld 408576698