Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1438453002: Use Feature directly in resolution. (Closed)

Created:
5 years, 1 month ago by Johnni Winther
Modified:
5 years, 1 month ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -170 lines) Patch
M pkg/compiler/lib/src/common/resolution.dart View 3 chunks +7 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend.dart View 1 chunk +4 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 2 chunks +26 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_impact.dart View 1 chunk +29 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/class_hierarchy.dart View 3 chunks +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/constructors.dart View 5 chunks +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 53 chunks +60 lines, -62 lines 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 7 chunks +19 lines, -83 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 3 chunks +5 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/type_resolver.dart View 4 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
Main changes in common/resolution.dart and resolution/registry.dart.
5 years, 1 month ago (2015-11-09 18:47:22 UTC) #2
sigurdm
LGTM
5 years, 1 month ago (2015-11-10 07:58:33 UTC) #3
Johnni Winther
5 years, 1 month ago (2015-11-10 09:47:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f92416c2b6f1dab40ebfc56e954fa362a8ef2509 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698