Use Feature directly in resolution.

pkg/compiler/lib/src/resolution/registry.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.resolution.registry;
 
 import '../common.dart';
 import '../common/backend_api.dart' show
     Backend,
     ForeignResolver;
@@ skipping 32 matching lines @@
     ResolverVisitor;
 import 'tree_elements.dart' show
     TreeElementMapping;
 
 class _ResolutionWorldImpact extends ResolutionImpact with WorldImpactBuilder {
   final String name;
   Setlet<Feature> _features;
   Setlet<MapLiteralUse> _mapLiterals;
   Setlet<ListLiteralUse> _listLiterals;
   Setlet<String> _constSymbolNames;
+  Setlet<ConstantExpression> _constantLiterals;
 
   _ResolutionWorldImpact(this.name);
 
   void registerMapLiteral(MapLiteralUse mapLiteralUse) {
     assert(mapLiteralUse != null);
     if (_mapLiterals == null) {
       _mapLiterals = new Setlet<MapLiteralUse>();
     }
     _mapLiterals.add(mapLiteralUse);
   }
@@ skipping 36 matching lines @@
       _features = new Setlet<Feature>();
     }
     _features.add(feature);
   }
 
   @override
   Iterable<Feature> get features {
     return _features != null ? _features : const <Feature>[];
   }
 
+  void registerConstantLiteral(ConstantExpression constant) {
+    if (_constantLiterals == null) {
+      _constantLiterals = new Setlet<ConstantExpression>();
+    }
+    _constantLiterals.add(constant);
+  }
+
+  Iterable<ConstantExpression> get constantLiterals {
+    return _constantLiterals != null
+        ? _constantLiterals : const <ConstantExpression>[];
+  }
+
   String toString() => '_ResolutionWorldImpact($name)';
 }
 
 /// [ResolutionRegistry] collects all resolution information. It stores node
 /// related information in a [TreeElements] mapping and registers calls with
 /// [Backend], [World] and [Enqueuer].
 // TODO(johnniwinther): Split this into an interface and implementation class.
 class ResolutionRegistry extends Registry {
   final Compiler compiler;
   final TreeElementMapping mapping;
@@ skipping 166 matching lines @@
   }
 
   //////////////////////////////////////////////////////////////////////////////
   //  Various Backend/Enqueuer/World registration.
   //////////////////////////////////////////////////////////////////////////////
 
   void registerStaticUse(StaticUse staticUse) {
     worldImpact.registerStaticUse(staticUse);
   }
 
-  void registerLazyField() {
-    worldImpact.registerFeature(Feature.LAZY_FIELD);
-  }
-
   void registerMetadataConstant(MetadataAnnotation metadata) {
     backend.registerMetadataConstant(metadata, metadata.annotatedElement, this);
   }
 
-  void registerThrowRuntimeError() {
-    worldImpact.registerFeature(Feature.THROW_RUNTIME_ERROR);
-  }
-
-  void registerCompileTimeError(ErroneousElement error) {
-    worldImpact.registerFeature(Feature.COMPILE_TIME_ERROR);
-  }
-
-  void registerTypeVariableBoundCheck() {
-    worldImpact.registerFeature(Feature.TYPE_VARIABLE_BOUNDS_CHECK);
-  }
-
-  void registerThrowNoSuchMethod() {
-    worldImpact.registerFeature(Feature.THROW_NO_SUCH_METHOD);
-  }
-
   /// Register the use of a type.
   void registerTypeUse(TypeUse typeUse) {
     worldImpact.registerTypeUse(typeUse);
   }
 
   void registerClosure(LocalFunctionElement element) {
     worldImpact.registerClosure(element);
   }
 
   void registerSuperUse(Node node) {
     mapping.addSuperUse(node);
   }
 
-  void registerSuperNoSuchMethod() {
-    worldImpact.registerFeature(Feature.SUPER_NO_SUCH_METHOD);
-  }
-
   void registerTypeLiteral(Send node, DartType type) {
     mapping.setType(node, type);
     worldImpact.registerTypeUse(new TypeUse.typeLiteral(type));
   }
 
   void registerLiteralList(Node node,
                            InterfaceType type,
                            {bool isConstant,
                             bool isEmpty}) {
     setType(node, type);
@@ skipping 16 matching lines @@
                            ResolverVisitor visitor) {
     backend.registerForeignCall(
         node, element, callStructure,
         new ForeignResolutionResolver(visitor, this));
   }
 
   void registerDynamicUse(DynamicUse dynamicUse) {
     worldImpact.registerDynamicUse(dynamicUse);
   }
 
+  void registerFeature(Feature feature) {
+    worldImpact.registerFeature(feature);
+  }
+
   void registerConstSymbol(String name) {
     worldImpact.registerConstSymbolName(name);
   }
 
-  void registerSymbolConstructor() {
-    worldImpact.registerFeature(Feature.SYMBOL_CONSTRUCTOR);
-  }
-
-  void registerAbstractClassInstantiation() {
-    worldImpact.registerFeature(Feature.ABSTRACT_CLASS_INSTANTIATION);
-  }
-
-  void registerStringInterpolation() {
-    worldImpact.registerFeature(Feature.STRING_INTERPOLATION);
-  }
-
-  void registerFallThroughError() {
-    worldImpact.registerFeature(Feature.FALL_THROUGH_ERROR);
-  }
-
-  void registerCatchStatement() {
-    worldImpact.registerFeature(Feature.CATCH_STATEMENT);
-  }
-
-  void registerStackTraceInCatch() {
-    worldImpact.registerFeature(Feature.STACK_TRACE_IN_CATCH);
-  }
-
-  void registerSyncForIn(Node node) {
-    worldImpact.registerFeature(Feature.SYNC_FOR_IN);
+  void registerConstantLiteral(ConstantExpression constant) {
+    worldImpact.registerConstantLiteral(constant);
   }
 
   ClassElement defaultSuperclass(ClassElement element) {
     return backend.defaultSuperclass(element);
   }
 
   void registerMixinUse(MixinApplicationElement mixinApplication,
                         ClassElement mixin) {
     universe.registerMixinUse(mixinApplication, mixin);
   }
 
-  void registerThrowExpression() {
-    worldImpact.registerFeature(Feature.THROW_EXPRESSION);
-  }
-
   void registerInstantiation(InterfaceType type) {
     worldImpact.registerTypeUse(new TypeUse.instantiation(type));
   }
 
-  void registerAssert(bool hasMessage) {
-    worldImpact.registerFeature(
-        hasMessage ? Feature.ASSERT_WITH_MESSAGE : Feature.ASSERT);
-  }
-
   void registerSendStructure(Send node, SendStructure sendStructure) {
     mapping.setSendStructure(node, sendStructure);
   }
 
   // TODO(johnniwinther): Remove this when [SendStructure]s are part of the
   // [ResolutionResult].
   SendStructure getSendStructure(Send node) {
     return mapping.getSendStructure(node);
   }
 
-  void registerAsyncMarker(FunctionElement element) {
-    switch (element.asyncMarker) {
-      case AsyncMarker.SYNC:
-        break;
-      case AsyncMarker.SYNC_STAR:
-        worldImpact.registerFeature(Feature.SYNC_STAR);
-        break;
-      case AsyncMarker.ASYNC:
-        worldImpact.registerFeature(Feature.ASYNC);
-        break;
-      case AsyncMarker.ASYNC_STAR:
-        worldImpact.registerFeature(Feature.ASYNC_STAR);
-        break;
-    }
-  }
-
-  void registerAsyncForIn(AsyncForIn node) {
-    worldImpact.registerFeature(Feature.ASYNC_FOR_IN);
-  }
-
-  void registerIncDecOperation() {
-    worldImpact.registerFeature(Feature.INC_DEC_OPERATION);
-  }
-
   void registerTryStatement() {
     mapping.containsTryStatement = true;
   }
 }
 
 class ForeignResolutionResolver implements ForeignResolver {
   final ResolverVisitor visitor;
   final ResolutionRegistry registry;
 
   ForeignResolutionResolver(this.visitor, this.registry);
 
   @override
   ConstantExpression getConstant(Node node) {
     return registry.getConstant(node);
   }
 
   @override
   void registerInstantiatedType(InterfaceType type) {
     registry.registerInstantiation(type);
   }
 
   @override
   DartType resolveTypeFromString(Node node, String typeName) {
     return visitor.resolveTypeFromString(node, typeName);
   }
 }