Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: pkg/compiler/lib/src/js_backend/backend.dart

Issue 1438453002: Use Feature directly in resolution. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/dart_backend/backend.dart ('k') | pkg/compiler/lib/src/js_backend/backend_impact.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_backend/backend.dart
diff --git a/pkg/compiler/lib/src/js_backend/backend.dart b/pkg/compiler/lib/src/js_backend/backend.dart
index 6c3c9ca138e40585f93e14b60504cb57b7c4353a..65b84697c4ca31e21d046597bdf2b4239b3d856a 100644
--- a/pkg/compiler/lib/src/js_backend/backend.dart
+++ b/pkg/compiler/lib/src/js_backend/backend.dart
@@ -2743,6 +2743,9 @@ class JavaScriptImpactTransformer extends ImpactTransformer {
case Feature.STRING_INTERPOLATION:
registerBackendImpact(transformed, impacts.stringInterpolation);
break;
+ case Feature.STRING_JUXTAPOSITION:
+ registerBackendImpact(transformed, impacts.stringJuxtaposition);
+ break;
case Feature.SUPER_NO_SUCH_METHOD:
registerBackendImpact(transformed, impacts.superNoSuchMethod);
break;
@@ -2856,6 +2859,29 @@ class JavaScriptImpactTransformer extends ImpactTransformer {
}
}
+ for (ConstantExpression constant in worldImpact.constantLiterals) {
+ switch (constant.kind) {
+ case ConstantExpressionKind.NULL:
+ registerBackendImpact(transformed, impacts.nullLiteral);
+ break;
+ case ConstantExpressionKind.BOOL:
+ registerBackendImpact(transformed, impacts.boolLiteral);
+ break;
+ case ConstantExpressionKind.INT:
+ registerBackendImpact(transformed, impacts.intLiteral);
+ break;
+ case ConstantExpressionKind.DOUBLE:
+ registerBackendImpact(transformed, impacts.doubleLiteral);
+ break;
+ case ConstantExpressionKind.STRING:
+ registerBackendImpact(transformed, impacts.stringLiteral);
+ break;
+ default:
+ assert(invariant(NO_LOCATION_SPANNABLE, false,
+ message: "Unexpected constant literal: ${constant.kind}."));
+ }
+ }
+
return transformed;
}
« no previous file with comments | « pkg/compiler/lib/src/dart_backend/backend.dart ('k') | pkg/compiler/lib/src/js_backend/backend_impact.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698