Issue 1438433004: Adds back lookup of 'all' targets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1438433004: Adds back lookup of 'all' targets (Closed)

Created:
5 years, 1 month ago by sky

Modified:
5 years, 1 month ago

Reviewers:
Mark Mentovai

CC:
gyp-developer_googlegroups.com

Base URL:
https://chromium.googlesource.com/external/gyp@master

Target Ref:
refs/heads/master

Project:
gyp

Visibility:
Public.

Adds back lookup of 'all' targets I'm going to add support for 'all'. This is a precursor to that. This patch effectively adds back code that was removed here: https://codereview.chromium.org/1402813002 . The code isn't wired up yet. Will do that next. TEST=none BUG=552146 R=mark@chromium.org Committed: https://chromium.googlesource.com/external/gyp/+/f54bd199e717008adbc40513dafc3f9f01f3487f

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -8 lines)			Patch
	M	pylib/gyp/generator/analyzer.py	View	1	6 chunks	+24 lines, -8 lines	0 comments	Download

Total messages: 3 (0 generated)

sky

5 years, 1 month ago (2015-11-09 21:48:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
f54bd199e717008adbc40513dafc3f9f01f3487f (presubmit successful).