Change analyzer to search for build_targets from supplied targets

Change analyzer to search for build_targets from supplied targets

Prior to this change build_targets returned targets that were children
of the root nodes. After this change build_targets are children of the
supplied targets.

This change better matches how we want to use analyzer. In particular
bots don't necessarily build all, so that returning a target that is
normally not build results in weird behavior (bot building things it
normally doesn't).

BUG=542337
TEST=covered by tests
R=dpranke@chromium.org, mark@chromium.org, scottmg@chromium.org

Committed: https://chromium.googlesource.com/external/gyp/+/3f21260b43401553c37bb28090b65a75577d5b4e

[sky, 2015-10-12 17:11:18]

sky@chromium.org changed reviewers:
+ mark@chromium.org
- scottmg@chromium.org

[Mark Mentovai, 2015-10-12 17:23:45]

LGTM

[Dirk Pranke, 2015-10-12 19:01:28]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2015-10-12 19:01:28]

https://codereview.chromium.org/1402813002/diff/40001/pylib/gyp/generator/ana...
File pylib/gyp/generator/analyzer.py (right):

https://codereview.chromium.org/1402813002/diff/40001/pylib/gyp/generator/ana...
pylib/gyp/generator/analyzer.py:39: as it is of type none with no rules and
actions.
I thought we agreed that we were going to get rid of 'targets' as an output that
is different than 'build_targets' (or at least make them both return the same
thing?

[sky, 2015-10-12 19:05:18]

https://codereview.chromium.org/1402813002/diff/40001/pylib/gyp/generator/ana...
File pylib/gyp/generator/analyzer.py (right):

https://codereview.chromium.org/1402813002/diff/40001/pylib/gyp/generator/ana...
pylib/gyp/generator/analyzer.py:39: as it is of type none with no rules and
actions.
On 2015/10/12 19:01:28, Dirk Pranke wrote:
> I thought we agreed that we were going to get rid of 'targets' as an output
that
> is different than 'build_targets' (or at least make them both return the same
> thing?

I'm fine with that, but wasn't sure about the staging of the changes. What is
recipes consuming now?

[Dirk Pranke, 2015-10-12 19:12:01]

On 2015/10/12 19:05:18, sky wrote:
>
https://codereview.chromium.org/1402813002/diff/40001/pylib/gyp/generator/ana...
> File pylib/gyp/generator/analyzer.py (right):
> 
>
https://codereview.chromium.org/1402813002/diff/40001/pylib/gyp/generator/ana...
> pylib/gyp/generator/analyzer.py:39: as it is of type none with no rules and
> actions.
> On 2015/10/12 19:01:28, Dirk Pranke wrote:
> > I thought we agreed that we were going to get rid of 'targets' as an output
> that
> > is different than 'build_targets' (or at least make them both return the
same
> > thing?
> 
> I'm fine with that, but wasn't sure about the staging of the changes. What is
> recipes consuming now?

The code currently consumes both fields and merges them together. We should
return the same value for both (for now), update the recipes, and then we can
remove one of the two values from analyzer.py.

[sky, 2015-10-12 23:53:14]

On 2015/10/12 19:12:01, Dirk Pranke wrote:
> On 2015/10/12 19:05:18, sky wrote:
> >
>
https://codereview.chromium.org/1402813002/diff/40001/pylib/gyp/generator/ana...
> > File pylib/gyp/generator/analyzer.py (right):
> > 
> >
>
https://codereview.chromium.org/1402813002/diff/40001/pylib/gyp/generator/ana...
> > pylib/gyp/generator/analyzer.py:39: as it is of type none with no rules and
> > actions.
> > On 2015/10/12 19:01:28, Dirk Pranke wrote:
> > > I thought we agreed that we were going to get rid of 'targets' as an
output
> > that
> > > is different than 'build_targets' (or at least make them both return the
> same
> > > thing?
> > 
> > I'm fine with that, but wasn't sure about the staging of the changes. What
is
> > recipes consuming now?
> 
> The code currently consumes both fields and merges them together. We should
> return the same value for both (for now), update the recipes, and then we can
> remove one of the two values from analyzer.py.

Dirk and myself talked. I'm going to change this patch to make targets output
the same thing as build_targets does. Once we've updated recipes I can then nuke
targets. I will do this shortly.

[sky, 2015-10-13 00:05:26]

Done, take another look?

[Dirk Pranke, 2015-10-13 04:29:23]

lgtm

[sky, 2015-10-14 15:35:53]

On 2015/10/13 04:29:23, Dirk Pranke wrote:
> lgtm

Mark, did you want to take another look?

[Mark Mentovai, 2015-10-20 13:00:44]

Still LGTM

[sky, 2015-10-20 21:37:11]

Committed patchset #4 (id:60001) manually as
3f21260b43401553c37bb28090b65a75577d5b4e (presubmit successful).