Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1437993003: Revert of [DevTools] Filter any messages from previous sessions in DevToolsAgentHostImpl (Closed)

Created:
5 years, 1 month ago by pfeldman
Modified:
5 years, 1 month ago
Reviewers:
Tom Sepez, kozy, dgozman
CC:
chromium-reviews, tzik, apavlov+blink_chromium.org, kinuko+watch, jsbell+serviceworker_chromium.org, caseq+blink_chromium.org, jam, dglazkov+blink, darin-cc_chromium.org, devtools-reviews_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-worker-reviews_chromium.org, mlamouri+watch-content_chromium.org, nhiroki, lushnikov+blink_chromium.org, michaeln, serviceworker-reviews, pfeldman+blink_chromium.org, kinuko+serviceworker, mkwst+moarreviews-renderer_chromium.org, horo+watch_chromium.org, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [DevTools] Filter any messages from previous sessions in DevToolsAgentHostImpl (patchset #6 id:120001 of https://codereview.chromium.org/1408363004/ ) Reason for revert: Rolling this out for breaking Inspect Element. Original issue's description: > [DevTools] Filter any messages from previous sessions in DevToolsAgentHostImpl > > Frontend can receive response for protocol message that was sent by previous session. E.g. frontend send protocol message and then reattach then get response. > session id for procol message is added in this CL. DevToolsAgentHostImpl store current session_id, RenderFrameDevToolsAgentHost and WorkerDevToolsAgentHost add to each protocol message session id and SendResponseMessageToClient method check it after processing. > > BUG=503875, 503824 > TEST=run blink/tools/run_layout_tests.py inspector/sources/debugger-breakpoints/set-conditional-breakpoint.html --repeat-each 2 > R=pfeldman@chromium.org, dgozman@chromium.org, tsepez@chromium.org > TBR=jam@chromium.org TBR=dgozman@chromium.org,tsepez@chromium.org,kozyatinskiy@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=503875, 503824 Committed: https://crrev.com/6274dfa569f4a0c738d8a4cf9015cae27edeb249 Cr-Commit-Position: refs/heads/master@{#359257}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+332 lines, -443 lines) Patch
M components/html_viewer/devtools_agent_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/html_viewer/devtools_agent_impl.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M content/browser/devtools/browser_devtools_agent_host.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M content/browser/devtools/devtools_agent_host_impl.h View 4 chunks +3 lines, -13 lines 0 comments Download
M content/browser/devtools/devtools_agent_host_impl.cc View 6 chunks +5 lines, -19 lines 0 comments Download
M content/browser/devtools/devtools_protocol_handler.h View 1 chunk +9 lines, -13 lines 0 comments Download
M content/browser/devtools/devtools_protocol_handler.cc View 4 chunks +37 lines, -43 lines 0 comments Download
M content/browser/devtools/forwarding_agent_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/protocol/devtools_protocol_client.h View 3 chunks +13 lines, -18 lines 0 comments Download
M content/browser/devtools/protocol/devtools_protocol_client.cc View 5 chunks +14 lines, -17 lines 0 comments Download
D content/browser/devtools/protocol/devtools_protocol_delegate.h View 1 chunk +0 lines, -22 lines 0 comments Download
M content/browser/devtools/protocol/devtools_protocol_handler_generator.py View 5 chunks +9 lines, -9 lines 0 comments Download
M content/browser/devtools/protocol/input_handler.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/devtools/protocol/tracing_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 9 chunks +24 lines, -31 lines 0 comments Download
M content/browser/devtools/worker_devtools_agent_host.cc View 5 chunks +17 lines, -11 lines 0 comments Download
M content/child/shared_worker_devtools_agent.h View 1 chunk +4 lines, -7 lines 0 comments Download
M content/child/shared_worker_devtools_agent.cc View 5 chunks +4 lines, -10 lines 0 comments Download
M content/common/devtools_messages.h View 2 chunks +7 lines, -13 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/devtools/devtools_agent.h View 3 chunks +10 lines, -15 lines 0 comments Download
M content/renderer/devtools/devtools_agent.cc View 5 chunks +26 lines, -33 lines 0 comments Download
M content/renderer/devtools/devtools_agent_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/devtools/devtools_agent_filter.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/service_worker/embedded_worker_devtools_agent.h View 1 chunk +3 lines, -5 lines 0 comments Download
M content/renderer/service_worker/embedded_worker_devtools_agent.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/renderer/shared_worker/embedded_shared_worker_stub.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/shared_worker/embedded_shared_worker_stub.cc View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/CodeGeneratorInspector.py View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/CodeGeneratorInspectorStrings.py View 13 chunks +39 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorFrontendChannel.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.h View 4 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 11 chunks +23 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp View 3 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp View 3 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/public/web/WebDevToolsAgent.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/public/web/WebDevToolsAgentClient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/web/WebEmbeddedWorker.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/public/web/WebSharedWorker.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/public/web/WebSharedWorkerClient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
pfeldman
Created Revert of [DevTools] Filter any messages from previous sessions in DevToolsAgentHostImpl
5 years, 1 month ago (2015-11-12 04:21:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1437993003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1437993003/1
5 years, 1 month ago (2015-11-12 04:22:40 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-12 04:24:24 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 20:04:49 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6274dfa569f4a0c738d8a4cf9015cae27edeb249
Cr-Commit-Position: refs/heads/master@{#359257}

Powered by Google App Engine
This is Rietveld 408576698