Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1091)

Unified Diff: content/browser/devtools/protocol/devtools_protocol_handler_generator.py

Issue 1437993003: Revert of [DevTools] Filter any messages from previous sessions in DevToolsAgentHostImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/devtools_protocol_handler_generator.py
diff --git a/content/browser/devtools/protocol/devtools_protocol_handler_generator.py b/content/browser/devtools/protocol/devtools_protocol_handler_generator.py
index 6377be6fdec6bdd7f2304e3daaa2a817da4f86ee..6bce71e604749801f63191a919c7c24633d9630f 100755
--- a/content/browser/devtools/protocol/devtools_protocol_handler_generator.py
+++ b/content/browser/devtools/protocol/devtools_protocol_handler_generator.py
@@ -74,11 +74,11 @@
class DevToolsProtocolDispatcher {
public:
+ using Notifier = DevToolsProtocolClient::RawMessageCallback;
using CommandHandler =
- base::Callback<bool(DevToolsCommandId,
- scoped_ptr<base::DictionaryValue>)>;
-
- explicit DevToolsProtocolDispatcher(DevToolsProtocolDelegate* notifier);
+ base::Callback<bool(int, scoped_ptr<base::DictionaryValue>)>;
+
+ explicit DevToolsProtocolDispatcher(const Notifier& notifier);
~DevToolsProtocolDispatcher();
CommandHandler FindCommandHandler(const std::string& method);
@@ -91,7 +91,7 @@
${methods}\
- DevToolsProtocolDelegate* notifier_;
+ Notifier notifier_;
DevToolsProtocolClient client_;
CommandHandlers command_handlers_;
${fields}\
@@ -208,7 +208,7 @@
namespace ${domain} {
class Client : public DevToolsProtocolClient {
public:
- explicit Client(DevToolsProtocolDelegate* notifier);
+ explicit Client(const RawMessageCallback& raw_message_callback);
~Client() override;
${methods}\
@@ -252,7 +252,7 @@
namespace content {
DevToolsProtocolDispatcher::DevToolsProtocolDispatcher(
- DevToolsProtocolDelegate* notifier)
+ const Notifier& notifier)
: notifier_(notifier),
client_(notifier),
${fields_init} {
@@ -405,8 +405,8 @@
tmpl_client_impl = string.Template("""\
namespace ${domain} {
-Client::Client(DevToolsProtocolDelegate* notifier)
- : DevToolsProtocolClient(notifier) {
+Client::Client(const RawMessageCallback& raw_message_callback)
+ : DevToolsProtocolClient(raw_message_callback) {
}
Client::~Client() {
« no previous file with comments | « content/browser/devtools/protocol/devtools_protocol_delegate.h ('k') | content/browser/devtools/protocol/input_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698