third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp - Issue 1437993003: Revert of [DevTools] Filter any messages from previous sessions in DevToolsAgentHostImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp

Issue 1437993003: Revert of [DevTools] Filter any messages from previous sessions in DevToolsAgentHostImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorFrontendChannel.h ('k') | third_party/WebKit/Source/web/WebDevToolsAgentImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp

diff --git a/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp b/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp

index eef82379c7bb09542842d16ba4f9b7a3b0848eb5..6e1493d99a8c68133dcd112305ca1a9bdb85e9d9 100644

--- a/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp

+++ b/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp

@@ -65,7 +65,7 @@

explicit PageInspectorProxy(WorkerGlobalScope* workerGlobalScope) : m_workerGlobalScope(workerGlobalScope) { }

~PageInspectorProxy() override { }

private:

- void sendProtocolResponse(int sessionId, int callId, PassRefPtr<JSONObject> message) override

+ void sendProtocolResponse(int callId, PassRefPtr<JSONObject> message) override

{

// Worker messages are wrapped, no need to handle callId.

m_workerGlobalScope->thread()->workerReportingProxy().postMessageToPageInspector(message->toJSONString());

@@ -197,10 +197,8 @@

void WorkerInspectorController::dispatchMessageFromFrontend(const String& message)

{

InspectorTaskRunner::IgnoreInterruptsScope scope(m_inspectorTaskRunner.get());

- if (m_backendDispatcher) {

- // sessionId will be overwritten by WebDevToolsAgent::sendProtocolNotifications call.

- m_backendDispatcher->dispatch(0, message);

- }

+ if (m_backendDispatcher)

+ m_backendDispatcher->dispatch(message);

}

void WorkerInspectorController::dispose()