[MD settings] adding page zoom options to appearnce settings

[MD settings] adding page zoom options to appearnce settings

This CL adds the page zoom dropdown menu to the Appearance settings.

BUG=531786

[dschuyler, 2015-11-09 22:47:45]

Description was changed from

==========
[MD settings] adding page zoom options to appearnce settings

This CL adds the page zoom dropdown menu to the Appearance settings.

BUG=531786
==========

to

==========
[MD settings] adding page zoom options to appearnce settings

This CL adds the page zoom dropdown menu to the Appearance settings.

BUG=531786
==========

[dschuyler, 2015-11-09 22:47:45]

dschuyler@chromium.org changed reviewers:
+ michaelpg@chromium.org

[michaelpg, 2015-11-09 23:59:45]

copy pasta?

https://codereview.chromium.org/1437543003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/appearance_page/appearance_page.html
(left):

https://codereview.chromium.org/1437543003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/appearance_page/appearance_page.html:91:
menuOptions="[[pageZoomOptions_]]">
why not keep this?

https://codereview.chromium.org/1437543003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/appearance_page/appearance_page.js
(right):

https://codereview.chromium.org/1437543003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/appearance_page/appearance_page.js:83: *
prefs.browser.clear_data.time_period.value enum.
wat

https://codereview.chromium.org/1437543003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/appearance_page/appearance_page.js:148:
onCustomizeFontsTap_: function() {
wat

[dschuyler, 2015-11-10 20:03:39]

https://codereview.chromium.org/1437543003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/appearance_page/appearance_page.html
(left):

https://codereview.chromium.org/1437543003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/appearance_page/appearance_page.html:91:
menuOptions="[[pageZoomOptions_]]">
On 2015/11/09 23:59:45, michaelpg wrote:
> why not keep this?

It didn't affect the results.

https://codereview.chromium.org/1437543003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/appearance_page/appearance_page.js
(right):

https://codereview.chromium.org/1437543003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/appearance_page/appearance_page.js:83: *
prefs.browser.clear_data.time_period.value enum.
On 2015/11/09 23:59:45, michaelpg wrote:
> wat

The same could apply to the fontSizeOptions_ above.

Done.

https://codereview.chromium.org/1437543003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/appearance_page/appearance_page.js:148:
onCustomizeFontsTap_: function() {
On 2015/11/09 23:59:45, michaelpg wrote:
> wat

I seem to have had some trouble merging code.

Done.

[Dan Beam, 2015-11-10 22:21:26]

https://codereview.chromium.org/1437543003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/appearance_page/appearance_page.js
(right):

https://codereview.chromium.org/1437543003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/appearance_page/appearance_page.js:148:
onCustomizeFontsTap_: function() {
On 2015/11/10 20:03:39, dschuyler wrote:
> On 2015/11/09 23:59:45, michaelpg wrote:
> > wat
> 
> I seem to have had some trouble merging code.
> 
> Done.

the review tools, turns out, can still be used to view your own code before
sending it to others, btw ;)

[michaelpg, 2015-11-11 02:09:41]

https://codereview.chromium.org/1437543003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/appearance_page/appearance_page.html
(right):

https://codereview.chromium.org/1437543003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/appearance_page/appearance_page.html:92:
menuOptions="[[pageZoomOptions_]]">
menu-options

https://codereview.chromium.org/1437543003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/appearance_page/appearance_page.js
(right):

https://codereview.chromium.org/1437543003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/appearance_page/appearance_page.js:166: // The
|percent| may be undefined on startup.
This is dumb. FWIW, I consider this a Polymer bug.
https://github.com/Polymer/docs/issues/1419

(I mean it's the right thing for you to do, but it's dumb that we have to do
it.)