Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1437543003: [MD settings] adding page zoom options to appearnce settings (Closed)

Created:
5 years, 1 month ago by dschuyler
Modified:
5 years, 1 month ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@appearance50o
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] adding page zoom options to appearnce settings This CL adds the page zoom dropdown menu to the Appearance settings. BUG=531786

Patch Set 1 #

Total comments: 7

Patch Set 2 : review changes #

Patch Set 3 : updated dropdown menu #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -4 lines) Patch
M chrome/browser/resources/settings/appearance_page/appearance_page.html View 1 2 2 chunks +2 lines, -1 line 1 comment Download
M chrome/browser/resources/settings/appearance_page/appearance_page.js View 1 2 4 chunks +72 lines, -3 lines 1 comment Download
M chrome/browser/resources/settings/appearance_page/compiled_resources.gyp View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
dschuyler
5 years, 1 month ago (2015-11-09 22:47:54 UTC) #3
michaelpg
copy pasta? https://codereview.chromium.org/1437543003/diff/1/chrome/browser/resources/settings/appearance_page/appearance_page.html File chrome/browser/resources/settings/appearance_page/appearance_page.html (left): https://codereview.chromium.org/1437543003/diff/1/chrome/browser/resources/settings/appearance_page/appearance_page.html#oldcode91 chrome/browser/resources/settings/appearance_page/appearance_page.html:91: menuOptions="[[pageZoomOptions_]]"> why not keep this? https://codereview.chromium.org/1437543003/diff/1/chrome/browser/resources/settings/appearance_page/appearance_page.js File ...
5 years, 1 month ago (2015-11-09 23:59:45 UTC) #4
dschuyler
https://codereview.chromium.org/1437543003/diff/1/chrome/browser/resources/settings/appearance_page/appearance_page.html File chrome/browser/resources/settings/appearance_page/appearance_page.html (left): https://codereview.chromium.org/1437543003/diff/1/chrome/browser/resources/settings/appearance_page/appearance_page.html#oldcode91 chrome/browser/resources/settings/appearance_page/appearance_page.html:91: menuOptions="[[pageZoomOptions_]]"> On 2015/11/09 23:59:45, michaelpg wrote: > why not ...
5 years, 1 month ago (2015-11-10 20:03:39 UTC) #5
Dan Beam
https://codereview.chromium.org/1437543003/diff/1/chrome/browser/resources/settings/appearance_page/appearance_page.js File chrome/browser/resources/settings/appearance_page/appearance_page.js (right): https://codereview.chromium.org/1437543003/diff/1/chrome/browser/resources/settings/appearance_page/appearance_page.js#newcode148 chrome/browser/resources/settings/appearance_page/appearance_page.js:148: onCustomizeFontsTap_: function() { On 2015/11/10 20:03:39, dschuyler wrote: > ...
5 years, 1 month ago (2015-11-10 22:21:26 UTC) #6
michaelpg
5 years, 1 month ago (2015-11-11 02:09:41 UTC) #7
https://codereview.chromium.org/1437543003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/appearance_page/appearance_page.html
(right):

https://codereview.chromium.org/1437543003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/appearance_page/appearance_page.html:92:
menuOptions="[[pageZoomOptions_]]">
menu-options

https://codereview.chromium.org/1437543003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/appearance_page/appearance_page.js
(right):

https://codereview.chromium.org/1437543003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/appearance_page/appearance_page.js:166: // The
|percent| may be undefined on startup.
This is dumb. FWIW, I consider this a Polymer bug.
https://github.com/Polymer/docs/issues/1419

(I mean it's the right thing for you to do, but it's dumb that we have to do
it.)

Powered by Google App Engine
This is Rietveld 408576698