[MD settings] adding closure compile for settings dropdown menu (and cleaning up)

[MD settings] adding closure compile for settings dropdown menu (and cleaning up)

This CL adds closure compilation for the settings_dropdown_menu code as
well as starting to address some feedback from Michael about the implementation.

BUG=425627

[dschuyler, 2015-11-10 19:00:20]

Description was changed from

==========
[MD settings] adding closure compile for settings dropdown menu (and cleaning
up)

This CL adds closure compilation for the settings_dropdown_menu code as
well as starting to address some feedback from Michael about the implementation.

BUG=425627
==========

to

==========
[MD settings] adding closure compile for settings dropdown menu (and cleaning
up)

This CL adds closure compilation for the settings_dropdown_menu code as
well as starting to address some feedback from Michael about the implementation.

BUG=425627
==========

[dschuyler, 2015-11-10 19:00:20]

dschuyler@chromium.org changed reviewers:
+ michaelpg@chromium.org

[dschuyler, 2015-11-10 19:06:18]

https://codereview.chromium.org/1432103002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/controls/compiled_resources.gyp (right):

https://codereview.chromium.org/1432103002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/controls/compiled_resources.gyp:22:
'target_name': 'settings_dropdown_menu',
This is the new entry.  The other changes are alphabetizing the depends.

[michaelpg, 2015-11-12 23:33:05]

Some questions that led to me writing
https://codereview.chromium.org/1422023012/.

https://codereview.chromium.org/1432103002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/controls/settings_dropdown_menu.js
(right):

https://codereview.chromium.org/1432103002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/controls/settings_dropdown_menu.js:24: * in
the settings.
add a sentence explaining the not-found item behavior

https://codereview.chromium.org/1432103002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/controls/settings_dropdown_menu.js:132:
result[String(this.menuOptions[i][0])] = i.toString();
btw, I think foo.toString() is more idiomatic than String(foo). I was being dumb
when I suggested String(foo).

https://codereview.chromium.org/1432103002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/controls/settings_dropdown_menu.js:140:
this.$.dropdownMenu.disabled = false;
I think disabling the control until the items are available is unnecessary and
will only exacerbate any FOUC. Unless I'm misunderstanding the purpose of this.

https://codereview.chromium.org/1432103002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/controls/settings_dropdown_menu.js:140:
this.$.dropdownMenu.disabled = false;
Also, what if I want a <settings-dropdown-menu disabled>? (that property will
probably have to be added soon or later, so we shouldn't override its effects)

https://codereview.chromium.org/1432103002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/controls/settings_dropdown_menu.js:152:
this.showNotFoundValue_ = true;
same note from the landed CL: a getter shouldn't add an item to the array, and
this looks like a getter.

https://codereview.chromium.org/1432103002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/controls/settings_dropdown_menu.js:154: return
(this.menuOptions.length).toString();
no need for associative parens

https://codereview.chromium.org/1432103002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/controls/settings_dropdown_menu.js:164: var
result = this.menuOptions[index];
don't index into an array with a string

https://codereview.chromium.org/1432103002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/controls/settings_dropdown_menu.js:178:
this.selectedValue_ = String(prefValue);
toString

https://codereview.chromium.org/1432103002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/controls/settings_dropdown_menu.js:189:
this.selectedValue_ = String(value);
toString