[DevTools] filter any messages from previous session in DevToolsAgentHostImpl

[DevTools] filter any messages from previous session in DevToolsAgentHostImpl

Frontend can receive response for protocol message that was sent by previous session or notification that was produced during previous session. E.g. frontend send protocol message and then reattach and then get response.
session_id for protocol message is added in this CL. DevToolsAgentHostImpl store current session_id, RenderFrameDevToolsAgentHost and WorkerDevToolsAgentHost add to each protocol message session id and SendResponseMessageToClient method check it after processing.
WebDevToolsAgentImpl get session_id from Attach or Reattach IPC message, clear session_id on Dettach message and use it for notifications.

BUG=503875, 503824
TEST=run blink/tools/run_layout_tests.py inspector/sources/debugger-breakpoints/set-conditional-breakpoint.html --repeat-each 2
R=pfeldman@chromium.org, dgozman@chromium.org
TBR=jam@chromium.org, tsepez@chromium.org

Committed: https://crrev.com/1084bdca601104f8eb99fa4ff11cc1397d8dd1af
Cr-Commit-Position: refs/heads/master@{#361008}

[kozy, 2015-11-13 02:37:45]

Pavel, ptal.
Relanding CL from https://codereview.chromium.org/1408363004/. Previous attempt
was reverted because if user opens DevTools by using inspect element then all
notifications will be filtered.
Current implementation of InspectElement produce Attach message to
WebDevToolsAgentImpl. If we call this method before AttachClient then
WebDevToolsAgentImple will receive 0 as session_id.
In this CL I've moved DevToolsAgentHost::InspectElement call after AttachClient
in method DevToolsWindow::InspectElement and checked that second InspectElement
call side in ShellDevToolsFrontend is always call AttachClient before
InspectElement.

[jam, 2015-11-13 17:20:56]

On 2015/11/13 02:37:45, kozyatinskiy wrote:
> Pavel, ptal.
> Relanding CL from https://codereview.chromium.org/1408363004/. Previous
attempt
> was reverted because if user opens DevTools by using inspect element then all
> notifications will be filtered.
> Current implementation of InspectElement produce Attach message to
> WebDevToolsAgentImpl. If we call this method before AttachClient then
> WebDevToolsAgentImple will receive 0 as session_id.
> In this CL I've moved DevToolsAgentHost::InspectElement call after
AttachClient
> in method DevToolsWindow::InspectElement and checked that second
InspectElement
> call side in ShellDevToolsFrontend is always call AttachClient before
> InspectElement.

do you need me to review anything? i didn't review the original

[pfeldman, 2015-11-13 17:37:38]

I'll take a look at it.

[pfeldman, 2015-11-13 17:38:12]

https://codereview.chromium.org/1437283003/diff/1/chrome/browser/devtools/dev...
File chrome/browser/devtools/devtools_window.cc (right):

https://codereview.chromium.org/1437283003/diff/1/chrome/browser/devtools/dev...
chrome/browser/devtools/devtools_window.cc:534: agent->InspectElement(x, y);
Lets land this separately.

[kozy, 2015-11-13 18:08:15]

On 2015/11/13 17:38:12, pfeldman wrote:
>
https://codereview.chromium.org/1437283003/diff/1/chrome/browser/devtools/dev...
> File chrome/browser/devtools/devtools_window.cc (right):
> 
>
https://codereview.chromium.org/1437283003/diff/1/chrome/browser/devtools/dev...
> chrome/browser/devtools/devtools_window.cc:534: agent->InspectElement(x, y);
> Lets land this separately.

I've extracted it to https://codereview.chromium.org/1440383002/

[kozy, 2015-11-13 18:10:10]

On 2015/11/13 17:20:56, jam wrote:
> On 2015/11/13 02:37:45, kozyatinskiy wrote:
> > Pavel, ptal.
> > Relanding CL from https://codereview.chromium.org/1408363004/. Previous
> attempt
> > was reverted because if user opens DevTools by using inspect element then
all
> > notifications will be filtered.
> > Current implementation of InspectElement produce Attach message to
> > WebDevToolsAgentImpl. If we call this method before AttachClient then
> > WebDevToolsAgentImple will receive 0 as session_id.
> > In this CL I've moved DevToolsAgentHost::InspectElement call after
> AttachClient
> > in method DevToolsWindow::InspectElement and checked that second
> InspectElement
> > call side in ShellDevToolsFrontend is always call AttachClient before
> > InspectElement.
> 
> do you need me to review anything? i didn't review the original

I've added you to inform about changes in components/html_viewer. Just FYI.

[Tom Sepez, 2015-11-16 17:30:39]

Messages LGTM.

[kozy, 2015-11-20 18:23:44]

InspectElement was extracted and landed.
please take a look.

[dgozman, 2015-11-20 20:25:07]

lgtm

https://codereview.chromium.org/1437283003/diff/20001/content/browser/devtool...
File content/browser/devtools/devtools_agent_host_impl.cc (right):

https://codereview.chromium.org/1437283003/diff/20001/content/browser/devtool...
content/browser/devtools/devtools_agent_host_impl.cc:163:
SendMessageToClient(session_id(), message);
seesion_id_

https://codereview.chromium.org/1437283003/diff/20001/content/browser/devtool...
File content/browser/devtools/devtools_agent_host_impl.h (right):

https://codereview.chromium.org/1437283003/diff/20001/content/browser/devtool...
content/browser/devtools/devtools_agent_host_impl.h:62: int session_id() {
return session_id_; }
Let's DCHECK(client_) to ensure nobody uses it when detached.

https://codereview.chromium.org/1437283003/diff/20001/content/browser/devtool...
File content/browser/devtools/protocol/devtools_protocol_delegate.h (right):

https://codereview.chromium.org/1437283003/diff/20001/content/browser/devtool...
content/browser/devtools/protocol/devtools_protocol_delegate.h:14: virtual
~DevToolsProtocolDelegate(){}
nit: space before {}

[kozy, 2015-11-21 00:49:00]

All done.

https://codereview.chromium.org/1437283003/diff/20001/content/browser/devtool...
File content/browser/devtools/devtools_agent_host_impl.cc (right):

https://codereview.chromium.org/1437283003/diff/20001/content/browser/devtool...
content/browser/devtools/devtools_agent_host_impl.cc:163:
SendMessageToClient(session_id(), message);
On 2015/11/20 20:25:07, dgozman wrote:
> seesion_id_

Done.

https://codereview.chromium.org/1437283003/diff/20001/content/browser/devtool...
File content/browser/devtools/devtools_agent_host_impl.h (right):

https://codereview.chromium.org/1437283003/diff/20001/content/browser/devtool...
content/browser/devtools/devtools_agent_host_impl.h:62: int session_id() {
return session_id_; }
On 2015/11/20 20:25:07, dgozman wrote:
> Let's DCHECK(client_) to ensure nobody uses it when detached.

Done.

https://codereview.chromium.org/1437283003/diff/20001/content/browser/devtool...
File content/browser/devtools/protocol/devtools_protocol_delegate.h (right):

https://codereview.chromium.org/1437283003/diff/20001/content/browser/devtool...
content/browser/devtools/protocol/devtools_protocol_delegate.h:14: virtual
~DevToolsProtocolDelegate(){}
On 2015/11/20 20:25:07, dgozman wrote:
> nit: space before {}

Done.

[kozy, 2015-11-21 00:49:14]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2015-11-21 00:49:15]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1437283003/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-11-21 00:51:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1437283003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1437283003/40001

[commit-bot: I haz the power, 2015-11-21 02:16:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-21 02:16:19]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[kozy, 2015-11-21 03:28:09]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2015-11-21 03:29:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1437283003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1437283003/40001

[commit-bot: I haz the power, 2015-11-21 05:40:58]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-21 05:41:40]

Patchset 3 (id:??) landed as
https://crrev.com/1084bdca601104f8eb99fa4ff11cc1397d8dd1af
Cr-Commit-Position: refs/heads/master@{#361008}