Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Unified Diff: content/child/shared_worker_devtools_agent.cc

Issue 1437283003: [DevTools] filter any messages from previous session in DevToolsAgentHostImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/shared_worker_devtools_agent.h ('k') | content/common/devtools_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/shared_worker_devtools_agent.cc
diff --git a/content/child/shared_worker_devtools_agent.cc b/content/child/shared_worker_devtools_agent.cc
index 26a51edf6dd7f0ef15bf4d0dd87e9ca476203823..9b1996fcb88485ac68fae189250616098774b7d0 100644
--- a/content/child/shared_worker_devtools_agent.cc
+++ b/content/child/shared_worker_devtools_agent.cc
@@ -44,6 +44,7 @@ bool SharedWorkerDevToolsAgent::OnMessageReceived(const IPC::Message& message) {
}
void SharedWorkerDevToolsAgent::SendDevToolsMessage(
+ int session_id,
int call_id,
const blink::WebString& msg,
const blink::WebString& state) {
@@ -55,6 +56,7 @@ void SharedWorkerDevToolsAgent::SendDevToolsMessage(
if (message.length() < kMaxMessageChunkSize) {
chunk.data.swap(message);
+ chunk.session_id = session_id;
chunk.call_id = call_id;
chunk.post_state = post_state;
chunk.is_last = true;
@@ -65,6 +67,7 @@ void SharedWorkerDevToolsAgent::SendDevToolsMessage(
for (size_t pos = 0; pos < message.length(); pos += kMaxMessageChunkSize) {
chunk.is_last = pos + kMaxMessageChunkSize >= message.length();
+ chunk.session_id = chunk.is_last ? session_id : 0;
chunk.call_id = chunk.is_last ? call_id : 0;
chunk.post_state = chunk.is_last ? post_state : std::string();
chunk.data = message.substr(pos, kMaxMessageChunkSize);
@@ -75,13 +78,15 @@ void SharedWorkerDevToolsAgent::SendDevToolsMessage(
}
}
-void SharedWorkerDevToolsAgent::OnAttach(const std::string& host_id) {
- webworker_->attachDevTools(WebString::fromUTF8(host_id));
+void SharedWorkerDevToolsAgent::OnAttach(const std::string& host_id,
+ int session_id) {
+ webworker_->attachDevTools(WebString::fromUTF8(host_id), session_id);
}
void SharedWorkerDevToolsAgent::OnReattach(const std::string& host_id,
+ int session_id,
const std::string& state) {
- webworker_->reattachDevTools(WebString::fromUTF8(host_id),
+ webworker_->reattachDevTools(WebString::fromUTF8(host_id), session_id,
WebString::fromUTF8(state));
}
@@ -90,8 +95,9 @@ void SharedWorkerDevToolsAgent::OnDetach() {
}
void SharedWorkerDevToolsAgent::OnDispatchOnInspectorBackend(
+ int session_id,
const std::string& message) {
- webworker_->dispatchDevToolsMessage(WebString::fromUTF8(message));
+ webworker_->dispatchDevToolsMessage(session_id, WebString::fromUTF8(message));
}
bool SharedWorkerDevToolsAgent::Send(IPC::Message* message) {
« no previous file with comments | « content/child/shared_worker_devtools_agent.h ('k') | content/common/devtools_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698