content/browser/devtools/protocol/input_handler.cc - Issue 1437283003: [DevTools] filter any messages from previous session in DevToolsAgentHostImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/input_handler.cc

Issue 1437283003: [DevTools] filter any messages from previous session in DevToolsAgentHostImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/protocol/devtools_protocol_handler_generator.py ('k') | content/browser/devtools/protocol/tracing_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/protocol/input_handler.cc

diff --git a/content/browser/devtools/protocol/input_handler.cc b/content/browser/devtools/protocol/input_handler.cc

index 0b4bdcc3f5422f1a0e2d1f189c2f28e9e545f084..c0def4e411b8b18386e76fc1f21f03d7f05e1fc7 100644

--- a/content/browser/devtools/protocol/input_handler.cc

+++ b/content/browser/devtools/protocol/input_handler.cc

@@ -398,8 +398,8 @@ void InputHandler::SynthesizeRepeatingScroll(

DevToolsCommandId command_id) {

if (!interaction_marker_name.empty()) {

// TODO(alexclarke): Can we move this elsewhere? It doesn't really fit here.

- TRACE_EVENT_COPY_ASYNC_BEGIN0("benchmark",

- interaction_marker_name.c_str(), command_id);

+ TRACE_EVENT_COPY_ASYNC_BEGIN0("benchmark", interaction_marker_name.c_str(),

+ command_id.call_id);

}

host_->QueueSyntheticGesture(

@@ -417,8 +417,8 @@ void InputHandler::OnScrollFinished(

DevToolsCommandId command_id,

SyntheticGesture::Result result) {

if (!interaction_marker_name.empty()) {

- TRACE_EVENT_COPY_ASYNC_END0("benchmark",

- interaction_marker_name.c_str(), command_id);

+ TRACE_EVENT_COPY_ASYNC_END0("benchmark", interaction_marker_name.c_str(),

+ command_id.call_id);

}

if (repeat_count > 0) {