Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1435303002: Temporarily add PrivetHttpClient::GetHost method (Closed)

Created:
5 years, 1 month ago by Vitaly Buka (NO REVIEWS)
Modified:
5 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@context1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Temporarily add PrivetHttpClient::GetHost method BUG=551631 Committed: https://crrev.com/94135efa12df3d877c1059534dc5a4eda68f4224 Cr-Commit-Position: refs/heads/master@{#359367}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/browser/extensions/api/gcd_private/privet_v3_session_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/local_discovery/privet_http.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1435743004 Patch 1

Dependent Patchsets:

Issue 1437193002 Patch 1

Messages

Total messages: 11 (4 generated)
Vitaly Buka (NO REVIEWS)
5 years, 1 month ago (2015-11-12 16:34:15 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435303002/1
5 years, 1 month ago (2015-11-12 16:35:00 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-12 18:40:48 UTC) #6
Aleksey Shlyapnikov
lgtm
5 years, 1 month ago (2015-11-12 19:36:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435303002/1
5 years, 1 month ago (2015-11-12 19:42:12 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-12 20:13:08 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 20:13:59 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/94135efa12df3d877c1059534dc5a4eda68f4224
Cr-Commit-Position: refs/heads/master@{#359367}

Powered by Google App Engine
This is Rietveld 408576698