Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 143703007: Tweak the public/protected/private sections of MediaControls (Closed)

Created:
6 years, 10 months ago by philipj_slow
Modified:
6 years, 10 months ago
CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Visibility:
Public.

Description

Tweak the public/protected/private sections of MediaControls After the merge this looked rather strange, so keep as public that which is used by HTMLMediaElement or MediaControlElements, make protected that which is used/overridden by MediaControlsAndroid, and make everything else private. BUG=341813 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166911

Patch Set 1 #

Total comments: 2

Patch Set 2 : annotate overrides #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -22 lines) Patch
M Source/core/html/shadow/MediaControls.h View 1 2 4 chunks +22 lines, -20 lines 0 comments Download
M Source/core/html/shadow/MediaControls.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
philipj_slow
Patch 4, depends on https://codereview.chromium.org/141323005/ https://codereview.chromium.org/130693008/ is all of the patches together in a trybot ...
6 years, 10 months ago (2014-02-07 13:30:17 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm https://codereview.chromium.org/143703007/diff/1/Source/core/html/shadow/MediaControls.h File Source/core/html/shadow/MediaControls.h (right): https://codereview.chromium.org/143703007/diff/1/Source/core/html/shadow/MediaControls.h#newcode102 Source/core/html/shadow/MediaControls.h:102: virtual bool willRespondToMouseMoveEvents() OVERRIDE { return true; } ...
6 years, 10 months ago (2014-02-07 22:08:40 UTC) #2
philipj_slow
https://codereview.chromium.org/143703007/diff/1/Source/core/html/shadow/MediaControls.h File Source/core/html/shadow/MediaControls.h (right): https://codereview.chromium.org/143703007/diff/1/Source/core/html/shadow/MediaControls.h#newcode102 Source/core/html/shadow/MediaControls.h:102: virtual bool willRespondToMouseMoveEvents() OVERRIDE { return true; } On ...
6 years, 10 months ago (2014-02-08 04:00:24 UTC) #3
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 10 months ago (2014-02-11 09:45:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/143703007/80001
6 years, 10 months ago (2014-02-11 09:45:13 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-11 11:00:58 UTC) #6
Message was sent while issue was closed.
Change committed as 166911

Powered by Google App Engine
This is Rietveld 408576698