Tweak the public/protected/private sections of MediaControls

Source/core/html/shadow/MediaControls.h

 /*
  * Copyright (C) 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 35 matching lines @@
     virtual ~MediaControls() {}
 
     static PassRefPtr<MediaControls> create(Document&);
 
     virtual void setMediaController(MediaControllerInterface*);
 
     void reset();
 
     void show();
     void hide();
-    void makeOpaque();
-    void makeTransparent();
-    virtual bool shouldHideControls();
 
     void bufferingProgressed();
     virtual void playbackStarted();
     void playbackProgressed();
     virtual void playbackStopped();
 
     void updateCurrentTimeDisplay();
     void showVolumeSlider();
 
     void changedMute();
     void changedVolume();
 
     void changedClosedCaptionsVisibility();
     void refreshClosedCaptionsButtonVisibility();
     void closedCaptionTracksChanged();
 
     void enteredFullscreen();
     void exitedFullscreen();
 
-    virtual bool willRespondToMouseMoveEvents() OVERRIDE { return true; }
+    void updateTextTrackDisplay();
+
+protected:
+    explicit MediaControls(Document&);
+
+    bool initializeControls(Document&);
+
+    virtual bool shouldHideControls();
+
+    virtual void insertTextTrackContainer(PassRefPtr<MediaControlTextTrackContainerElement>);
+
+private:
+    void makeOpaque();
+    void makeTransparent();
 
     void hideFullscreenControlsTimerFired(Timer<MediaControls>*);
     void startHideFullscreenControlsTimer();
     void stopHideFullscreenControlsTimer();
 
     void createTextTrackDisplay();
     void showTextTrackDisplay();
     void hideTextTrackDisplay();
-    void updateTextTrackDisplay();
-    virtual void insertTextTrackContainer(PassRefPtr<MediaControlTextTrackContainerElement>);
 
-protected:
-    explicit MediaControls(Document&);
+    virtual bool isMediaControls() const OVERRIDE FINAL { return true; }
 
-    bool initializeControls(Document&);
+    virtual const AtomicString& shadowPseudoId() const OVERRIDE;
 
+    virtual bool willRespondToMouseMoveEvents() OVERRIDE { return true; }

[acolwell GONE FROM CHROMIUM, 2014/02/07 22:08:40]

nit: Please add a comment indicating that these are Node methods.

[philipj_slow, 2014/02/08 04:00:24]

Done.

     virtual void defaultEventHandler(Event*) OVERRIDE;
-
     bool containsRelatedTarget(Event*);
 
     MediaControllerInterface* m_mediaController;
 
     // Container for the media control elements.
     MediaControlPanelElement* m_panel;
 
     // Container for the text track cues.
     MediaControlTextTrackContainerElement* m_textDisplayContainer;
 
     // Media control elements.
     MediaControlPlayButtonElement* m_playButton;
     MediaControlCurrentTimeDisplayElement* m_currentTimeDisplay;
     MediaControlTimelineElement* m_timeline;
     MediaControlPanelMuteButtonElement* m_panelMuteButton;
     MediaControlPanelVolumeSliderElement* m_volumeSlider;
     MediaControlToggleClosedCaptionsButtonElement* m_toggleClosedCaptionsButton;
     MediaControlFullscreenButtonElement* m_fullScreenButton;
+    MediaControlTimeRemainingDisplayElement* m_durationDisplay;
+    MediaControlPanelEnclosureElement* m_enclosure;
 
     Timer<MediaControls> m_hideFullscreenControlsTimer;
     bool m_isFullscreen;
     bool m_isMouseOverControls;
-
-private:
-    virtual bool isMediaControls() const OVERRIDE FINAL { return true; }
-
-    virtual const AtomicString& shadowPseudoId() const OVERRIDE;
-
-    MediaControlTimeRemainingDisplayElement* m_durationDisplay;
-    MediaControlPanelEnclosureElement* m_enclosure;
 };
 
 DEFINE_NODE_TYPE_CASTS(MediaControls, isMediaControls());
 
 }
 
 #endif