Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 130693008: DO NOT LAND MediaControls trybot run (Closed)

Created:
6 years, 10 months ago by philipj_slow
Modified:
6 years, 10 months ago
Reviewers:
CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Visibility:
Public.

Description

Tweak the public/protected/private sections of MediaControls After the merge this looked rather strange, so keep as public that which is used by HTMLMediaElement or MediaControlElements, make protected that which is used/overridden by MediaControlsAndroid, and make everything else private. BUG=341813 Make MediaControls minimally virtual Only the functions which are overridden in MediaControlsAndroid need be virtual. updateStatusDisplay() didn't do anything, so it was removed. BUG=341813 Rename MediaControlsChromiumAndroid to MediaControlsAndroid BUG=341813 Merge MediaControlsChromium into MediaControls To the largest extent possible, code was copied from MediaControlsChromium.* to MediaControls.* without modification. Where MediaControlsChromium virtual functions called the MediaControls base functions, the order was preserved to avoid changing behavior. BUG=341813

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -516 lines) Patch
M Source/core/core.gypi View 1 chunk +4 lines, -6 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 2 chunks +1 line, -6 lines 0 comments Download
M Source/core/html/shadow/MediaControls.h View 2 chunks +41 lines, -38 lines 0 comments Download
M Source/core/html/shadow/MediaControls.cpp View 8 chunks +133 lines, -2 lines 0 comments Download
A + Source/core/html/shadow/MediaControlsAndroid.h View 2 chunks +4 lines, -7 lines 0 comments Download
A + Source/core/html/shadow/MediaControlsAndroid.cpp View 3 chunks +11 lines, -16 lines 0 comments Download
D Source/core/html/shadow/MediaControlsChromium.h View 1 chunk +0 lines, -65 lines 0 comments Download
D Source/core/html/shadow/MediaControlsChromium.cpp View 1 chunk +0 lines, -223 lines 0 comments Download
D Source/core/html/shadow/MediaControlsChromiumAndroid.h View 1 chunk +0 lines, -54 lines 0 comments Download
D Source/core/html/shadow/MediaControlsChromiumAndroid.cpp View 1 chunk +0 lines, -99 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698