Switch uses of SkChecksum::Compute to Murmur3.

Switch uses of SkChecksum::Compute to Murmur3.

SkChecksum::Compute is a very, very poorly distributed hash function.
This replaces all remaining uses with Murmur3.

The only interesting stuff is in src/gpu.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/1d024a3c909ae5cefa5e8b339e2b52dc73ee85ac

Committed: https://skia.googlesource.com/skia/+/540e95483d285b555e9b1a73d18c16e7d7c0deba

Committed: https://skia.googlesource.com/skia/+/56da02502019cfbb817898e37e320539b9838e2b

[mtklein, 2015-11-11 23:00:10]

The CQ bit was checked by mtklein@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-11 23:00:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1436973003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1436973003/20001

[commit-bot: I haz the power, 2015-11-11 23:12:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-11 23:12:08]

Dry run: This issue passed the CQ dry run.

[mtklein_C, 2015-11-12 18:55:58]

Description was changed from

==========
Delete SkChecksum::Compute

It's a very, very poorly distributed hash function.
This replaces all remaining uses with Murmur3.

It is quite fast, though, so it may have been filling an important niche.
We'll want to keep an eye on this CL for performance regressions.

BUG=skia:
==========

to

==========
Switch uses of SkChecksum::Compute to Murmur3.

SkChecksum::Compute is a very, very poorly distributed hash function.
This replaces all remaining uses with Murmur3.

BUG=skia:
==========

[mtklein_C, 2015-11-12 18:56:41]

Description was changed from

==========
Switch uses of SkChecksum::Compute to Murmur3.

SkChecksum::Compute is a very, very poorly distributed hash function.
This replaces all remaining uses with Murmur3.

BUG=skia:
==========

to

==========
Switch uses of SkChecksum::Compute to Murmur3.

SkChecksum::Compute is a very, very poorly distributed hash function.
This replaces all remaining uses with Murmur3.

The only interesting stuff is in src/gpu.

BUG=skia:
==========

[mtklein_C, 2015-11-12 18:56:48]

mtklein@chromium.org changed reviewers:
+ bsalomon@google.com
- mtklein@google.com

[bsalomon, 2015-11-12 21:06:40]

lgtm

[mtklein, 2015-11-12 23:32:54]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2015-11-12 23:33:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1436973003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1436973003/20001

[commit-bot: I haz the power, 2015-11-12 23:44:12]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/1d024a3c909ae5cefa5e8b339e2b52dc73ee85ac

[mtklein, 2015-11-13 15:07:33]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1445523003/ by mtklein@google.com.

The reason for reverting is: I would not have expected this to change any
images.

Looks like it's changed both MSAA and non-MSAA GMs:
https://gold.skia.org/search2?blame=1d024a3c909ae5cefa5e8b339e2b52dc73ee85ac&....

[dogben, 2015-11-13 16:14:04]

On 2015/11/13 at 15:07:33, mtklein wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1445523003/ by mtklein@google.com.
> 
> The reason for reverting is: I would not have expected this to change any
images.
> 
> Looks like it's changed both MSAA and non-MSAA GMs:
>
https://gold.skia.org/search2?blame=1d024a3c909ae5cefa5e8b339e2b52dc73ee85ac&....

This also seems to have caused nanobench on Nexus10 to run very very slowly:
Before:
http://build.chromium.org/p/client.skia.android/builders/Perf-Android-GCC-Nex...
After:
http://build.chromium.org/p/client.skia.android/builders/Perf-Android-GCC-Nex...

[mtklein_C, 2015-11-16 16:05:32]

The CQ bit was checked by mtklein@chromium.org

[mtklein_C, 2015-11-16 16:05:33]

Going to try this again.  We thought perhaps the diffs were a different CL, and
if not it'll be nice to see what they look like again.

[commit-bot: I haz the power, 2015-11-16 16:05:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1436973003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1436973003/20001

[commit-bot: I haz the power, 2015-11-16 16:13:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-16 16:13:34]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[mtklein_C, 2015-11-16 16:56:15]

The CQ bit was checked by mtklein@chromium.org

[commit-bot: I haz the power, 2015-11-16 16:56:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1436973003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1436973003/20001

[commit-bot: I haz the power, 2015-11-16 17:08:24]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/540e95483d285b555e9b1a73d18c16e7d7c0deba

[mtklein, 2015-11-16 19:01:00]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1448023005/ by mtklein@google.com.

The reason for reverting is: gotta put back *compute = 0..

[mtklein, 2015-11-16 19:03:54]

The CQ bit was checked by mtklein@google.com

[mtklein, 2015-11-16 19:03:54]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1436973003/#ps40001
(title: "fix")

[commit-bot: I haz the power, 2015-11-16 19:04:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1436973003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1436973003/40001

[commit-bot: I haz the power, 2015-11-16 19:16:26]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/56da02502019cfbb817898e37e320539b9838e2b