Retry landing "Implement zone-allocated types"

Retry landing "Implement zone-allocated types"

Works around apparent scoping bug in VS, the only change to before being a method rename in the test suite:

--- a/test/cctest/test-types.cc
+++ b/test/cctest/test-types.cc
@@ -153,7 +153,7 @@ struct ZoneRep {
     return reinterpret_cast<ZoneList<ZoneType*>*>(AsTagged(t));
   }

-  static Zone* Region(Zone* zone, Isolate* isolate) { return zone; }
+  static Zone* ToRegion(Zone* zone, Isolate* isolate) { return zone; }
 };

@@ -168,7 +168,7 @@ struct HeapRep {
   static Object* AsConstant(Handle<Type> t) { return Box::cast(*t)->value(); }
   static FixedArray* AsUnion(Handle<Type> t) { return FixedArray::cast(*t); }

-  static Isolate* Region(Zone* zone, Isolate* isolate) { return isolate; }
+  static Isolate* ToRegion(Zone* zone, Isolate* isolate) { return isolate; }
 };

@@ -183,7 +183,7 @@ struct Tests : Rep {
       isolate(CcTest::i_isolate()),
       scope(isolate),
       zone(isolate),
-      T(Rep::Region(&zone, isolate), isolate) {
+      T(Rep::ToRegion(&zone, isolate), isolate) {
   }

   static void CheckEqual(TypeHandle type1, TypeHandle type2) {

R=titzer@chromium.org
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=18711

[titzer, 2014-01-21 12:39:03]

lgtm with small comments

https://codereview.chromium.org/143693003/diff/1/src/list-inl.h
File src/list-inl.h (right):

https://codereview.chromium.org/143693003/diff/1/src/list-inl.h#newcode169
src/list-inl.h:169: ASSERT(pos <= length_);
pos >= 0 &&

Thank you, 
-- signed types

https://codereview.chromium.org/143693003/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/143693003/diff/1/src/objects.cc#newcode7909
src/objects.cc:7909: ASSERT(new_length <= length());
Here as well

[rossberg, 2014-01-21 14:03:08]

https://codereview.chromium.org/143693003/diff/1/src/list-inl.h
File src/list-inl.h (right):

https://codereview.chromium.org/143693003/diff/1/src/list-inl.h#newcode169
src/list-inl.h:169: ASSERT(pos <= length_);
On 2014/01/21 12:39:06, titzer wrote:
> pos >= 0 &&

Done.

https://codereview.chromium.org/143693003/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/143693003/diff/1/src/objects.cc#newcode7909
src/objects.cc:7909: ASSERT(new_length <= length());
On 2014/01/21 12:39:06, titzer wrote:
> Here as well

Done.

[rossberg, 2014-01-21 14:14:21]

Committed patchset #2 manually as r18711 (presubmit successful).