Oilpan: tidy up InspectorResourceContentLoader's ResourceClient handling.

Oilpan: tidy up InspectorResourceContentLoader's ResourceClient handling.

R=haraken
BUG=553613
Committed: https://crrev.com/f67dd9763cbf755a060b1da50d95af6e4fca0b52
Cr-Commit-Position: refs/heads/master@{#359553}

[sof, 2015-11-12 21:09:32]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[haraken, 2015-11-13 11:55:04]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2015-11-13 11:55:04]

LGTM

https://codereview.chromium.org/1436723005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.h
(right):

https://codereview.chromium.org/1436723005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.h:49:
WillBeHeapHashSet<RawPtrWillBeMember<ResourceClient>> m_pendingResourceClients;

Nit: It would be better to make this WillBeHeapHashSet<OwnPtrWillBeMember<>>
(but it's up to you since oilpan will be shipped in the near future).

[sof, 2015-11-13 13:57:20]

Description was changed from

==========
Oilpan: tidy up InspectorResourceContentLoader's ResourceClient handling.

R=
BUG=553613
==========

to

==========
Oilpan: tidy up InspectorResourceContentLoader's ResourceClient handling.

R=haraken
BUG=553613
==========

[sof, 2015-11-13 13:57:27]

https://codereview.chromium.org/1436723005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.h
(right):

https://codereview.chromium.org/1436723005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.h:49:
WillBeHeapHashSet<RawPtrWillBeMember<ResourceClient>> m_pendingResourceClients;
On 2015/11/13 11:55:04, haraken wrote:
> 
> Nit: It would be better to make this WillBeHeapHashSet<OwnPtrWillBeMember<>>
> (but it's up to you since oilpan will be shipped in the near future).

The ResourceClients here self-destruct, which they need to do post stop(), so
arranging for them to be owned by InspectorResourceContentLoader will require
too much of a rethink !OILPAN.

[sof, 2015-11-13 13:57:37]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2015-11-13 13:58:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1436723005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1436723005/1

[commit-bot: I haz the power, 2015-11-13 15:15:58]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-11-13 15:17:09]

Patchset 1 (id:??) landed as
https://crrev.com/f67dd9763cbf755a060b1da50d95af6e4fca0b52
Cr-Commit-Position: refs/heads/master@{#359553}